Issue 865383003: Consolidate callers to scheduleVisualUpdate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 865383003: Consolidate callers to scheduleVisualUpdate. (Closed)

Created:
5 years, 11 months ago by esprehn

Modified:
5 years, 11 months ago

Reviewers:
abarth-chromium, ojan

CC:
ojan, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Consolidate callers to scheduleVisualUpdate. Make everyone call through Document::scheduleVisualUpdate(). I also removed some dead composited selection code that used this. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/303625b64ce176f4b97a1655dbedf453a25d7c92

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -36 lines)			Patch
M	sky/engine/core/dom/Document.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/engine/core/dom/Document.cpp	View	1 chunk	+9 lines, -1 line	0 comments	Download
M	sky/engine/core/editing/FrameSelection.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/editing/FrameSelection.cpp	View	3 chunks	+3 lines, -18 lines	0 comments	Download
M	sky/engine/core/editing/InputMethodController.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/engine/core/frame/FrameView.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/engine/core/html/HTMLCanvasElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/rendering/RenderImageResource.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/rendering/RenderObject.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/rendering/RenderObject.cpp	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	sky/engine/platform/RuntimeEnabledFeatures.in	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

esprehn

5 years, 11 months ago (2015-01-23 02:47:27 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
303625b64ce176f4b97a1655dbedf453a25d7c92 (presubmit successful).