sky/engine/core/rendering/RenderObject.cpp - Issue 865383003: Consolidate callers to scheduleVisualUpdate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderObject.cpp

Issue 865383003: Consolidate callers to scheduleVisualUpdate. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderObject.cpp

diff --git a/sky/engine/core/rendering/RenderObject.cpp b/sky/engine/core/rendering/RenderObject.cpp

index 596e71a0e1124c7fb7fa12da8c86e6e40b739e2f..1fb6cdbea4838dc2f7fd4b7d48ab84d2ac30c65d 100644

--- a/sky/engine/core/rendering/RenderObject.cpp

+++ b/sky/engine/core/rendering/RenderObject.cpp

@@ -1939,7 +1939,7 @@ void RenderObject::imageChanged(ImageResource* image, const IntRect* rect)

void RenderObject::imageChanged(WrappedImagePtr, const IntRect*)

{

if (parent())

- scheduleVisualUpdate();

+ document().scheduleVisualUpdate();

}

Element* RenderObject::offsetParent() const

@@ -2047,11 +2047,6 @@ bool RenderObject::isRelayoutBoundaryForInspector() const

return objectIsRelayoutBoundary(this);

}

-void RenderObject::scheduleVisualUpdate()

- frame()->page()->animator().scheduleVisualUpdate();

bool RenderObject::isAllowedToModifyRenderTreeStructure(Document& document)

{

return document.lifecycle().stateAllowsRenderTreeMutations();