Chromium Code Reviews| Index: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm |
| diff --git a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm |
| index 9651817b430394de539299e78ce83bf4766a0cbb..892f901d6462c96a27361029171f5e8ce68560da 100644 |
| --- a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm |
| +++ b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm |
| @@ -444,15 +444,18 @@ class ExtensionLoadedNotificationObserver |
| IDS_EXTENSION_INSTALLED_SIGNIN_PROMO_LINK)); |
| NSString* message(l10n_util::GetNSStringWithFixup( |
| IDS_EXTENSION_INSTALLED_SIGNIN_PROMO)); |
| + if ([link length] != 0) { |
|
Alexei Svitkine (slow)
2015/01/23 18:41:02
When would the link length be 0?
Alexei Svitkine (slow)
2015/01/23 19:14:18
I don't think this error handling is necessary - I
|
| + message = [link stringByAppendingString:message]; |
| + } |
| HyperlinkTextView* view = promo_.get(); |
| - [view setMessageAndLink:message |
| - withLink:link |
| - atOffset:0 |
| - font:font |
| - messageColor:[NSColor blackColor] |
| - linkColor:gfx::SkColorToCalibratedNSColor( |
| - chrome_style::GetLinkColor())]; |
| + [view setMessage:message withFont:font messageColor:[NSColor blackColor]]; |
| + if ([link length] != 0) { |
|
Alexei Svitkine (slow)
2015/01/23 18:41:01
Ditto.
|
| + [view addLinkRange:NSMakeRange(0, [link length]) |
| + withName:@"" |
| + linkColor:gfx::SkColorToCalibratedNSColor( |
| + chrome_style::GetLinkColor())]; |
| + } |
| // HACK! The TextView does not report correct height even after you stuff |
| // it with text (it tells you it is single-line even if it is multiline), so |