Removed calls to [HyperlinkTextView setMessageAndLink:withLink:...]

chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.h"
 
 #include "base/i18n/rtl.h"
 #include "base/mac/bundle_locations.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/sys_string_conversions.h"
@@ skipping 426 matching lines @@
 
   int sync_promo_height = 0;
   if ([self showSyncPromo]) {
     // First calculate the height of the sign-in promo.
     NSFont* font = [NSFont systemFontOfSize:[NSFont smallSystemFontSize]];
 
     NSString* link(l10n_util::GetNSStringWithFixup(
         IDS_EXTENSION_INSTALLED_SIGNIN_PROMO_LINK));
     NSString* message(l10n_util::GetNSStringWithFixup(
         IDS_EXTENSION_INSTALLED_SIGNIN_PROMO));
+    if ([link length] != 0) {

[Alexei Svitkine (slow), 2015/01/23 18:41:02]

When would the link length be 0?

[Alexei Svitkine (slow), 2015/01/23 19:14:18]

I don't think this error handling is necessary - I don't think we do it anywhere
else. If there is actually a problem, we'll see it in crash reports and can
address it - but until then I'd keep the code simpler.

+      message = [link stringByAppendingString:message];
+    }
 
     HyperlinkTextView* view = promo_.get();
-    [view setMessageAndLink:message
-                   withLink:link
-                   atOffset:0
-                       font:font
-               messageColor:[NSColor blackColor]
-                  linkColor:gfx::SkColorToCalibratedNSColor(
-                                chrome_style::GetLinkColor())];
+    [view setMessage:message withFont:font messageColor:[NSColor blackColor]];
+    if ([link length] != 0) {

[Alexei Svitkine (slow), 2015/01/23 18:41:01]

Ditto.

+      [view addLinkRange:NSMakeRange(0, [link length])
+                withName:@""
+               linkColor:gfx::SkColorToCalibratedNSColor(
+                                                chrome_style::GetLinkColor())];
+    }
 
     // HACK! The TextView does not report correct height even after you stuff
     // it with text (it tells you it is single-line even if it is multiline), so
     // here the hidden howToUse_ TextField is temporarily repurposed to
     // calculate the correct height for the TextView.
     [[howToUse_ cell] setAttributedStringValue:[promo_ attributedString]];
     [GTMUILocalizerAndLayoutTweaker
           sizeToFitFixedWidthTextField:howToUse_];
     sync_promo_height = NSHeight([howToUse_ frame]);
   }
@@ skipping 231 matching lines @@
   install_ui->OpenAppInstalledUI(extension_->id());
 }
 
 - (void)awakeFromNib {
   if (bundle_)
     return;
   [self initializeLabel];
 }
 
 @end