Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 865363002: Disable PNaCl for V2 app (Closed)

Created:
5 years, 11 months ago by Sergey Ulanov
Modified:
5 years, 11 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@xmpp_assert
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable PNaCl for V2 app Now remoting_webapp_v2 doesn't use PNaCl. Also added new target remoting_webapp_v2_pnacl that does use PNaCl. BUG=451184 Committed: https://crrev.com/ac752bfcd5e31b79e2ea27cecd3ac3466b864e6e Cr-Commit-Position: refs/heads/master@{#312890}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -13 lines) Patch
M remoting/remoting_client.gypi View 1 2 chunks +27 lines, -13 lines 2 comments Download

Messages

Total messages: 9 (2 generated)
Sergey Ulanov
5 years, 11 months ago (2015-01-23 00:09:40 UTC) #2
Jamie
https://codereview.chromium.org/865363002/diff/20001/remoting/remoting_client.gypi File remoting/remoting_client.gypi (right): https://codereview.chromium.org/865363002/diff/20001/remoting/remoting_client.gypi#newcode120 remoting/remoting_client.gypi:120: ['disable_nacl==0 and disable_nacl_untrusted==0', { Do we need the "untrusted" ...
5 years, 11 months ago (2015-01-23 00:47:16 UTC) #3
Sergey Ulanov
https://codereview.chromium.org/865363002/diff/20001/remoting/remoting_client.gypi File remoting/remoting_client.gypi (right): https://codereview.chromium.org/865363002/diff/20001/remoting/remoting_client.gypi#newcode120 remoting/remoting_client.gypi:120: ['disable_nacl==0 and disable_nacl_untrusted==0', { On 2015/01/23 00:47:16, Jamie wrote: ...
5 years, 11 months ago (2015-01-23 01:00:16 UTC) #4
Jamie
lgtm
5 years, 11 months ago (2015-01-23 01:10:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865363002/20001
5 years, 11 months ago (2015-01-23 18:05:34 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-23 19:09:39 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 19:10:33 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ac752bfcd5e31b79e2ea27cecd3ac3466b864e6e
Cr-Commit-Position: refs/heads/master@{#312890}

Powered by Google App Engine
This is Rietveld 408576698