Disable PNaCl for V2 app

remoting/remoting_client.gypi

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       # GN version: //remoting/client/plugin
       'target_name': 'remoting_client_plugin',
       'type': 'static_library',
@@ skipping 98 matching lines @@
       ],
     },  # end of target 'remoting_webapp_html'
 
     {
       'target_name': 'remoting_webapp',
       'type': 'none',
       'dependencies': [
         'remoting_webapp_v1',
         'remoting_webapp_v2',
       ],
+      'conditions': [
+        ['disable_nacl==0 and disable_nacl_untrusted==0', {

[Jamie, 2015/01/23 00:47:16]

Do we need the "untrusted" variable? As it is, setting "disable_nacl = 0" is not
sufficient to cause the nacl version to be built, which doesn't seem right. For
these two variable to work as their name suggests, I feel like we would need two
additional web-app target.

[Sergey Ulanov, 2015/01/23 01:00:16]

This is the condition that's used in other places to build (P)NaCl bits.
disable_nacl and disable_nacl_untrusted are set to 0 by default, so
remoting_webapp_v2_pnacl should be built by default. Setting either disable_nacl
or disable_nacl_untrusted to 1 allows to disable it.

+          'dependencies': [
+            'remoting_webapp_v2_pnacl',
+          ],
+        }]
+      ],
     },  # end of target 'remoting_webapp'
 
     {
       'target_name': 'remoting_webapp_v1',
       'type': 'none',
       'variables': {
         'webapp_type': 'v1',
         'output_dir': '<(PRODUCT_DIR)/remoting/remoting.webapp',
         'zip_path': '<(PRODUCT_DIR)/remoting-webapp.zip',
       },
       'includes': [ 'remoting_webapp.gypi', ],
     },  # end of target 'remoting_webapp_v1'
 
     {
       'target_name': 'remoting_webapp_v2',
       'type': 'none',
       'variables': {
         'output_dir': '<(PRODUCT_DIR)/remoting/remoting.webapp.v2',
         'zip_path': '<(PRODUCT_DIR)/remoting-webapp.v2.zip',
+        'webapp_type': 'v2',
       },
-      'conditions': [
-        ['disable_nacl==0 and disable_nacl_untrusted==0', {
-          'dependencies': [
-            'remoting_nacl.gyp:remoting_client_plugin_nacl',
-          ],
+      'includes': [ 'remoting_webapp.gypi', ],
+    },  # end of target 'remoting_webapp_v2'
+  ],  # end of targets
+
+  'conditions': [
+    ['disable_nacl==0 and disable_nacl_untrusted==0', {
+      'targets': [
+        {
+          'target_name': 'remoting_webapp_v2_pnacl',
+          'type': 'none',
           'variables': {
+            'output_dir': '<(PRODUCT_DIR)/remoting/remoting.webapp.v2_pnacl',
+            'zip_path': '<(PRODUCT_DIR)/remoting-webapp.v2_pnacl.zip',
             'webapp_type': 'v2_pnacl',
             'extra_files': [
               'webapp/crd/remoting_client_pnacl.nmf',
               '<(PRODUCT_DIR)/remoting_client_plugin_newlib.pexe',
             ],
           },
-        }, {
-          'variables': {
-            'webapp_type': 'v2',
-          },
-        }],
+          'dependencies': [
+            'remoting_nacl.gyp:remoting_client_plugin_nacl',
+          ],
+          'includes': [ 'remoting_webapp.gypi', ],
+        },  # end of target 'remoting_webapp_v2_pnacl'
       ],
-      'includes': [ 'remoting_webapp.gypi', ],
-    },  # end of target 'remoting_webapp_v2'
-  ],  # end of targets
+    }],
+  ],
 }