Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 865313004: GMs now use batch (Closed)

Created:
5 years, 10 months ago by joshua.litt
Modified:
5 years, 10 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@oval
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : updating gyp #

Patch Set 3 : rebase on master #

Patch Set 4 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+356 lines, -72 lines) Patch
M gm/beziereffects.cpp View 7 chunks +177 lines, -46 lines 0 comments Download
M gm/convexpolyeffect.cpp View 5 chunks +79 lines, -26 lines 0 comments Download
M gyp/gmslides.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A src/gpu/GrTestBatch.h View 1 2 3 1 chunk +98 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
joshualitt
5 years, 10 months ago (2015-02-09 19:04:06 UTC) #2
bsalomon
lgtm
5 years, 10 months ago (2015-02-10 15:08:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865313004/20001
5 years, 10 months ago (2015-02-10 15:12:10 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/1921)
5 years, 10 months ago (2015-02-10 15:13:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865313004/20001
5 years, 10 months ago (2015-02-11 19:27:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865313004/40001
5 years, 10 months ago (2015-02-11 19:29:19 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/3f284d7758d7f35b59d93a22d126f7cd8423be44
5 years, 10 months ago (2015-02-11 19:35:02 UTC) #15
joshualitt
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/913153003/ by joshualitt@google.com. ...
5 years, 10 months ago (2015-02-11 21:02:11 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/865313004/60001
5 years, 10 months ago (2015-02-11 21:39:17 UTC) #18
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 21:45:55 UTC) #19
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/95964c670b577d5f49c5eab7af277ad987fd0519

Powered by Google App Engine
This is Rietveld 408576698