Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 864973003: Fixing and re-enabling WebRTC/AppRTC integration test. (Closed)

Created:
5 years, 11 months ago by phoglund_chromium
Modified:
5 years, 10 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing and re-enabling WebRTC/AppRTC integration test. This patch needs to land after https://codereview.chromium.org/872423002/ since the path to the AppRTC code changes. BUG=451985 Committed: https://crrev.com/8bfd83942cc2b151f0e277c574da9d0a0ace6207 Cr-Commit-Position: refs/heads/master@{#313514}

Patch Set 1 #

Patch Set 2 : Correctly enabling the ff test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
phoglund_chromium
Seems we're in a good state now with the infrastructure: please review.
5 years, 10 months ago (2015-01-28 13:05:21 UTC) #2
kjellander_chromium
lgtm
5 years, 10 months ago (2015-01-28 13:12:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864973003/1
5 years, 10 months ago (2015-01-28 13:36:03 UTC) #5
phoglund_chromium
On 2015/01/28 13:36:03, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 10 months ago (2015-01-28 14:41:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864973003/20001
5 years, 10 months ago (2015-01-28 14:43:15 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-28 15:17:45 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 15:18:37 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8bfd83942cc2b151f0e277c574da9d0a0ace6207
Cr-Commit-Position: refs/heads/master@{#313514}

Powered by Google App Engine
This is Rietveld 408576698