Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc

Issue 864973003: Fixing and re-enabling WebRTC/AppRTC integration test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Correctly enabling the ff test Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc
diff --git a/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc b/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc
index 6eada11a6506618863c658c141f6d268337aeadb..bda25781d1fb6a245d3cce2b389c4fb29f88c74f 100644
--- a/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc
+++ b/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc
@@ -84,7 +84,8 @@ class WebRtcApprtcBrowserTest : public WebRtcTestBase {
}
base::FilePath apprtc_dir =
- GetSourceDir().Append(FILE_PATH_LITERAL("out/apprtc"));
+ GetSourceDir().Append(FILE_PATH_LITERAL(
+ "out/webrtc-samples/samples/web/content/apprtc"));
if (!base::PathExists(apprtc_dir)) {
LOG(ERROR) << "Missing AppRTC code at " <<
apprtc_dir.value() << ". " << kAdviseOnGclientSolution;
@@ -223,7 +224,7 @@ class WebRtcApprtcBrowserTest : public WebRtcTestBase {
base::Process collider_server_;
};
-IN_PROC_BROWSER_TEST_F(WebRtcApprtcBrowserTest, DISABLED_MANUAL_WorksOnApprtc) {
+IN_PROC_BROWSER_TEST_F(WebRtcApprtcBrowserTest, MANUAL_WorksOnApprtc) {
// Disabled on Win XP: http://code.google.com/p/webrtc/issues/detail?id=2703.
if (OnWinXp())
return;
@@ -254,7 +255,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcApprtcBrowserTest, DISABLED_MANUAL_WorksOnApprtc) {
}
#if defined(OS_LINUX)
-#define MAYBE_MANUAL_FirefoxApprtcInteropTest DISABLED_MANUAL_FirefoxApprtcInteropTest
+#define MAYBE_MANUAL_FirefoxApprtcInteropTest MANUAL_FirefoxApprtcInteropTest
#else
// Not implemented yet on Windows and Mac.
#define MAYBE_MANUAL_FirefoxApprtcInteropTest DISABLED_MANUAL_FirefoxApprtcInteropTest
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698