Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 864953004: XFA: make FPDFViewEmbeddertest.Crashers test run successfully. (Closed)

Created:
5 years, 11 months ago by Tom Sepez
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

XFA: make FPDFViewEmbeddertest.Crashers test run successfully. XFA is pickier, and returns false when loading some mangled documents. TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/a946e3a8854b09c2130c92f1ae24cb796a0f9095

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M fpdfsdk/src/fpdfview_embeddertest.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Tom Sepez
FYI ... just fixing a test result.
5 years, 11 months ago (2015-01-27 01:18:30 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as a946e3a8854b09c2130c92f1ae24cb796a0f9095 (presubmit successful).
5 years, 11 months ago (2015-01-27 01:18:38 UTC) #2
Lei Zhang
Shouldn't the two branches both return true? Are we out of sync because we didn't ...
5 years, 11 months ago (2015-01-27 02:23:43 UTC) #3
Tom Sepez
On 2015/01/27 02:23:43, Lei Zhang wrote: > Shouldn't the two branches both return true? Are ...
5 years, 10 months ago (2015-01-27 18:56:16 UTC) #4
Lei Zhang
5 years, 10 months ago (2015-01-27 19:23:33 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698