fpdfsdk/src/fpdfview_embeddertest.cpp - Issue 864953004: XFA: make FPDFViewEmbeddertest.Crashers test run successfully.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fpdfview_embeddertest.cpp

Issue 864953004: XFA: make FPDFViewEmbeddertest.Crashers test run successfully. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/fpdfview_embeddertest.cpp

diff --git a/fpdfsdk/src/fpdfview_embeddertest.cpp b/fpdfsdk/src/fpdfview_embeddertest.cpp

index 14a6532a5894c4e95de6c2c58af89464467a81ac..76dd9a57984a6ed07adb3dc54072a5f5e19b9ded 100644

--- a/fpdfsdk/src/fpdfview_embeddertest.cpp

+++ b/fpdfsdk/src/fpdfview_embeddertest.cpp

@@ -180,5 +180,6 @@ TEST_F(FPDFViewEmbeddertest, NamedDestsByName) {

// The following tests pass if the document opens without crashing.

TEST_F(FPDFViewEmbeddertest, Crashers) {

- EXPECT_TRUE(OpenDocument("testing/resources/bug_451830.pdf"));

+ // XFA branch detects this document as bad.

+ EXPECT_FALSE(OpenDocument("testing/resources/bug_451830.pdf"));

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »