Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 864873003: Revert of Ipclist fixes. (Closed)

Created:
5 years, 11 months ago by Nico
Modified:
5 years, 10 months ago
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Ipclist fixes. (patchset #2 id:20001 of https://codereview.chromium.org/848453003/) Reason for revert: The review doesn't show it, but this added back third_party/libc++(abi) for some reason: https://chromium.googlesource.com/chromium/src/+/faf8b453fa03869b3109258702ca7cf7b8157f5b This was moved elsewhere in https://codereview.chromium.org/788063003 and it being back causes all kinds of things, for example me being unable to run `git cl upload`. Please reland this without adding back libc++. Original issue's description: > Ipclist fixes. > > 1. Make it work with Windows. > 2. Remove non-existent messages. > 3. Use _generator.h files where possible, e.g. adds missing extension_utility_messages.h. > > R=gunsch@chromium.org, tsepez@chromium.org > TBR=ttuttle@chromium.org > BUG=450268 > > Committed: https://chromium.googlesource.com/chromium/src/+/faf8b453fa03869b3109258702ca7cf7b8157f5b TBR=tsepez@chromium.org,gunsch@chromium.org,jar@chromium.org,ttuttle@chromium.org,inferno@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=450268

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -21 lines) Patch
M chromecast/common/media/cma_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_message_start.h View 3 chunks +3 lines, -0 lines 0 comments Download
M tools/ipc_fuzzer/ipclist/ipclist.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M tools/ipc_fuzzer/message_lib/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M tools/ipc_fuzzer/message_lib/all_messages.h View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Nico
Created Revert of Ipclist fixes.
5 years, 11 months ago (2015-01-21 21:14:12 UTC) #1
Nico
Bleh, looks like this isn't reverting the libc++ bits. Reverting manually…
5 years, 11 months ago (2015-01-21 21:15:14 UTC) #3
Deprecated (see juliatuttle)
On 2015/01/21 21:15:14, Nico wrote: > Bleh, looks like this isn't reverting the libc++ bits. ...
5 years, 10 months ago (2015-01-30 19:27:31 UTC) #4
Nico
5 years, 10 months ago (2015-01-30 19:31:08 UTC) #5
Message was sent while issue was closed.
On 2015/01/30 19:27:31, ttuttle wrote:
> On 2015/01/21 21:15:14, Nico wrote:
> > Bleh, looks like this isn't reverting the libc++ bits. Reverting manually…
> 
> Can you close this change if it's not going to land?

Sure, done. (If this bothers you, I think you can do this yourself too. I tend
to not clean up old stuff I ended up not using, as a quick look at
https://codereview.chromium.org/user/thakis@chromium.org will show you ;-) )

Powered by Google App Engine
This is Rietveld 408576698