Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 788063003: Move libc++ and libc++abi to buildtools. (Closed)

Created:
6 years ago by Michael Achenbach
Modified:
5 years, 11 months ago
CC:
chromium-reviews, inferno, kcc2, earthdok, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move libc++ and libc++abi to buildtools. BUG=443987 Committed: https://crrev.com/9747e7da7a886f18b4d584d64dca83fdf7b7da12 Cr-Commit-Position: refs/heads/master@{#311026}

Patch Set 1 #

Patch Set 2 : Remove gitignore #

Total comments: 2

Patch Set 3 : Review + depend on external buildtools deps roll. #

Patch Set 4 : Rebase to buildtools roll and licence whitelist update. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -223 lines) Patch
M .gitignore View 1 1 chunk +0 lines, -2 lines 0 comments Download
M DEPS View 1 2 3 2 chunks +0 lines, -8 lines 0 comments Download
M build/common.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M build/sanitizers/sanitizers.gyp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D third_party/libc++/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/libc++/README.chromium View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/libc++/libc++.gyp View 1 chunk +0 lines, -117 lines 0 comments Download
D third_party/libc++abi/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/libc++abi/README.chromium View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/libc++abi/libc++abi.gyp View 1 chunk +0 lines, -60 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 24 (7 generated)
Michael Achenbach
Preliminary - need to roll buildtools. I could also roll buildtools in a separate CL ...
6 years ago (2014-12-19 13:07:01 UTC) #3
Alexander Potapenko
rubberstamp lgtm
6 years ago (2014-12-19 13:30:35 UTC) #4
earthdok
https://codereview.chromium.org/788063003/diff/20001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/788063003/diff/20001/build/common.gypi#newcode4323 build/common.gypi:4323: '<(DEPTH)/buildtools/libc++/libc++.gyp:libcxx_proxy', build/sanitizers/sanitizers.gyp also references this location
6 years ago (2014-12-19 17:44:00 UTC) #5
Michael Achenbach
Done. This now depends on the buildtools roll https://codereview.chromium.org/800713005/ https://codereview.chromium.org/788063003/diff/20001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/788063003/diff/20001/build/common.gypi#newcode4323 build/common.gypi:4323: ...
6 years ago (2014-12-23 09:14:19 UTC) #6
earthdok
On 2014/12/23 09:14:19, Michael Achenbach wrote: > Done. This now depends on the buildtools roll ...
6 years ago (2014-12-23 14:55:34 UTC) #7
Michael Achenbach
+ Pawel for the licence whitelist removal. The latest patch also points to the new ...
5 years, 11 months ago (2015-01-09 09:32:02 UTC) #9
Paweł Hajdan Jr.
LGTM
5 years, 11 months ago (2015-01-09 09:33:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788063003/60001
5 years, 11 months ago (2015-01-09 09:34:42 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/34436)
5 years, 11 months ago (2015-01-09 09:40:43 UTC) #14
Michael Achenbach
+ brettw, jam or cpu for owner's review
5 years, 11 months ago (2015-01-09 09:50:59 UTC) #16
jochen (gone - plz use gerrit)
this lgtm
5 years, 11 months ago (2015-01-09 13:02:25 UTC) #17
brettw
lgtm
5 years, 11 months ago (2015-01-12 08:53:54 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788063003/60001
5 years, 11 months ago (2015-01-12 08:57:10 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-12 09:01:28 UTC) #21
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/9747e7da7a886f18b4d584d64dca83fdf7b7da12 Cr-Commit-Position: refs/heads/master@{#311026}
5 years, 11 months ago (2015-01-12 09:02:17 UTC) #22
Michael Achenbach
This CL might be the reason for the ASAN debug breakage: http://build.chromium.org/p/chromium.lkgr/builders/ASAN%20Debug/builds/9775/steps/compile/logs/stdio Does anybody know ...
5 years, 11 months ago (2015-01-17 17:17:25 UTC) #23
Michael Achenbach
5 years, 11 months ago (2015-01-18 10:45:52 UTC) #24
Message was sent while issue was closed. 
The bot turned red long after this CL got into the lkgr.

The last successful lkgr-build is based on
https://chromium.googlesource.com/chromium/src/+/8be8b4d8e65c4d02219a3c6923cf...
which is already ~900 revisions after this. The culprit must be in this range:
https://chromium.googlesource.com/chromium/src/+log/8be8b4d8e65c4d02219a3c692...

My guess is thakis' CL:
https://chromium.googlesource.com/chromium/src/+/faffc1a04d17dd977ff9eb335c0c...

Powered by Google App Engine
This is Rietveld 408576698