Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 864873002: Autofill - don't respect autocomplete="off" for mac address book or (Closed)

Created:
5 years, 11 months ago by Evan Stade
Modified:
5 years, 11 months ago
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autofill - don't respect autocomplete="off" for mac address book or scan credit card suggestions. BUG=450680 Committed: https://crrev.com/5c598826de5e95c7f41b6e07f470d2962b8ed9cc Cr-Commit-Position: refs/heads/master@{#312566}

Patch Set 1 #

Patch Set 2 : fix mac test expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/autofill/core/browser/autofill_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Evan Stade
While I was AFKing, it occurred to me the culprit was probably autocomplete="off". Seems I ...
5 years, 11 months ago (2015-01-21 18:48:45 UTC) #2
please use gerrit instead
lgtm
5 years, 11 months ago (2015-01-21 20:20:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864873002/1
5 years, 11 months ago (2015-01-21 21:38:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/25436)
5 years, 11 months ago (2015-01-21 22:23:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864873002/20001
5 years, 11 months ago (2015-01-22 03:50:21 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-22 05:31:08 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 05:31:58 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5c598826de5e95c7f41b6e07f470d2962b8ed9cc
Cr-Commit-Position: refs/heads/master@{#312566}

Powered by Google App Engine
This is Rietveld 408576698