components/autofill/core/browser/autofill_manager.cc - Issue 864873002: Autofill - don't respect autocomplete="off" for mac address book or

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 864873002: Autofill - don't respect autocomplete="off" for mac address book or (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix mac test expectation Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/autofill/core/browser/autofill_manager.cc

diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc

index 18bd355fe2a60a4296e5c7ce817efdc55cebf634..b9123d0674c4f40feaa014629ccaeed59e2d437e 100644

--- a/components/autofill/core/browser/autofill_manager.cc

+++ b/components/autofill/core/browser/autofill_manager.cc

@@ -1108,7 +1108,7 @@ bool AutofillManager::GetCachedFormAndField(const FormData& form,

AutofillField* AutofillManager::GetAutofillField(const FormData& form,

const FormFieldData& field) {

- if (!personal_data_ || !field.should_autocomplete)

+ if (!personal_data_)

return NULL;

FormStructure* form_structure = NULL;

« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_manager_unittest.cc » ('j') | no next file with comments »