Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 864853002: remove drawType from optState (Closed)

Created:
5 years, 11 months ago by joshua.litt
Modified:
5 years, 11 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove drawType from optState BUG=skia: Committed: https://skia.googlesource.com/skia/+/b77e4b6bf08b1619982d0a835ab4daf693aefcb6

Patch Set 1 #

Total comments: 1

Patch Set 2 : cleaning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -33 lines) Patch
M src/gpu/GrGpu.h View 1 chunk +5 lines, -2 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 4 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/GrOptDrawState.h View 3 chunks +1 line, -4 lines 0 comments Download
M src/gpu/GrOptDrawState.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProgram.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 4 chunks +3 lines, -9 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/GLProgramsTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
joshualitt
Removing drawtype from OptState
5 years, 11 months ago (2015-01-21 16:55:34 UTC) #3
bsalomon
lgtm https://codereview.chromium.org/864853002/diff/1/src/gpu/gl/GrGLGpu.cpp File src/gpu/gl/GrGLGpu.cpp (right): https://codereview.chromium.org/864853002/diff/1/src/gpu/gl/GrGLGpu.cpp#newcode1366 src/gpu/gl/GrGLGpu.cpp:1366: fCurrentProgram->setData(*args.fPrimitiveProcessor, optState, *args.fBatchTracker, curious how is draw type ...
5 years, 11 months ago (2015-01-21 17:43:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864853002/20001
5 years, 11 months ago (2015-01-21 18:09:20 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 18:16:22 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b77e4b6bf08b1619982d0a835ab4daf693aefcb6

Powered by Google App Engine
This is Rietveld 408576698