Add a slide-in pane to the OOP PDF viewer.

Add a slide-in pane to the OOP PDF viewer.

This CL adds the groundwork for a slide-in pane to be used by the OOP PDF Viewer. It adheres to the principles of Material Design, and will be used as a base for the bookmarks pane (which will display a list of bookmarks) as well as an info pane to show metadata of the PDF.

BUG=110020
Committed: https://crrev.com/01e81ff908f129955e769d96b8626ae127a90a0e
Cr-Commit-Position: refs/heads/master@{#313631}

[Alexandre Carlton, 2015-01-21 07:29:25]

alexandrec@chromium.org changed reviewers:
+ raymes@chromium.org, sammc@chromium.org

[Alexandre Carlton, 2015-01-21 07:29:26]

First version of slide-in pane.

[Alexandre Carlton, 2015-01-22 04:59:49]

alexandrec@chromium.org changed reviewers:
+ benwells@chromium.org

[Alexandre Carlton, 2015-01-22 04:59:49]

Prevented paper-dialog from scrolling back to the top when toggling.

[Sam McNally, 2015-01-22 06:56:02]

lgtm

[Alexandre Carlton, 2015-01-22 22:14:31]

alexandrec@chromium.org changed reviewers:
+ estade@chromium.org

[Alexandre Carlton, 2015-01-22 22:14:32]

estade@chromium.org: Please review changes in 

chrome/browser/resources/component_extension_resources.grd
ui/webui/resources/polymer_resources.grdp

Thank you again.

[Evan Stade, 2015-01-22 22:26:00]

lgtm

[raymes, 2015-01-23 00:03:26]

Can we make the CL description more descriptive? It should refer to the PDF
viewer and the material design revamp

[raymes, 2015-01-23 00:16:46]

lgtm

https://codereview.chromium.org/864753002/diff/160001/chrome/browser/resource...
File chrome/browser/resources/pdf/elements/pdf-pane/pdf-pane.css (right):

https://codereview.chromium.org/864753002/diff/160001/chrome/browser/resource...
chrome/browser/resources/pdf/elements/pdf-pane/pdf-pane.css:8: direction: rtl;
Maybe add a comment about this is here. i.e. 
/* Since the pane slides in from the right-hand side of the screen,
 * we want the scrollbar to be on the left. direction-rtl achieves
 * this.
 */
(Please make sure the comment spans 80chars)

https://codereview.chromium.org/864753002/diff/160001/chrome/browser/resource...
File chrome/browser/resources/pdf/elements/pdf-pane/pdf-pane.html (right):

https://codereview.chromium.org/864753002/diff/160001/chrome/browser/resource...
chrome/browser/resources/pdf/elements/pdf-pane/pdf-pane.html:8: <paper-dialog
id="pdialog" heading="{{heading}}" transition="core-transition-right"
class="scrolling pane" layered="false">
Can we make the id "paper-dialog"?

[Alexandre Carlton, 2015-01-23 00:25:11]

https://codereview.chromium.org/864753002/diff/160001/chrome/browser/resource...
File chrome/browser/resources/pdf/elements/pdf-pane/pdf-pane.css (right):

https://codereview.chromium.org/864753002/diff/160001/chrome/browser/resource...
chrome/browser/resources/pdf/elements/pdf-pane/pdf-pane.css:8: direction: rtl;
On 2015/01/23 00:16:46, raymes wrote:
> Maybe add a comment about this is here. i.e. 
> /* Since the pane slides in from the right-hand side of the screen,
>  * we want the scrollbar to be on the left. direction-rtl achieves
>  * this.
>  */
> (Please make sure the comment spans 80chars)

Done.

https://codereview.chromium.org/864753002/diff/160001/chrome/browser/resource...
File chrome/browser/resources/pdf/elements/pdf-pane/pdf-pane.html (right):

https://codereview.chromium.org/864753002/diff/160001/chrome/browser/resource...
chrome/browser/resources/pdf/elements/pdf-pane/pdf-pane.html:8: <paper-dialog
id="pdialog" heading="{{heading}}" transition="core-transition-right"
class="scrolling pane" layered="false">
On 2015/01/23 00:16:46, raymes wrote:
> Can we make the id "paper-dialog"?

Polymer allows access to internal elements through "this.$.<id>" (see
pdf-pane.js). Having a hyphen would force us to use "this.$['<id>']", which I'd
rather avoid. Would "dialog" be a better id?

[benwells, 2015-01-27 02:14:16]

https://codereview.chromium.org/864753002/diff/200001/chrome/browser/resource...
File chrome/browser/resources/pdf/elements/pdf-pane/pdf-pane.html (right):

https://codereview.chromium.org/864753002/diff/200001/chrome/browser/resource...
chrome/browser/resources/pdf/elements/pdf-pane/pdf-pane.html:8: <paper-dialog
id="dialog" heading="{{heading}}" transition="core-transition-right"
class="scrolling pane" layered="false">
Isn't layered=false the default?

[Alexandre Carlton, 2015-01-27 03:11:47]

https://codereview.chromium.org/864753002/diff/200001/chrome/browser/resource...
File chrome/browser/resources/pdf/elements/pdf-pane/pdf-pane.html (right):

https://codereview.chromium.org/864753002/diff/200001/chrome/browser/resource...
chrome/browser/resources/pdf/elements/pdf-pane/pdf-pane.html:8: <paper-dialog
id="dialog" heading="{{heading}}" transition="core-transition-right"
class="scrolling pane" layered="false">
On 2015/01/27 02:14:16, benwells wrote:
> Isn't layered=false the default?

The default is layered=true in paper-dialog-base (paper-dialog extends this
element):
https://www.polymer-project.org/docs/elements/paper-elements.html#paper-dialo...

It is false by default in core-overlay:
https://www.polymer-project.org/docs/elements/core-elements.html#core-overlay

[benwells, 2015-01-27 04:26:16]

lgtm

[Alexandre Carlton, 2015-01-28 22:14:56]

The CQ bit was checked by alexandrec@chromium.org

[commit-bot: I haz the power, 2015-01-28 22:16:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/864753002/220001

[commit-bot: I haz the power, 2015-01-29 00:08:45]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2015-01-29 00:09:39]

Patchset 12 (id:??) landed as
https://crrev.com/01e81ff908f129955e769d96b8626ae127a90a0e
Cr-Commit-Position: refs/heads/master@{#313631}