chrome/browser/resources/pdf/elements/pdf-pane/pdf-pane.html - Issue 864753002: Add a slide-in pane to the OOP PDF viewer.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/pdf/elements/pdf-pane/pdf-pane.html

Issue 864753002: Add a slide-in pane to the OOP PDF viewer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pdf-toolbar

Patch Set: Put scrollbar of pane on the left Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/polymer/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/paper-dialog/paper-dialog.ht ml">

	3

	4 <polymer-element name="pdf-pane" attributes="heading">

	5 <template>

	6 <link rel="stylesheet" href="pdf-pane.css">

	7 <!-- We set layered to false so that we can apply css in our file. -->

	8 <paper-dialog id="pdialog" heading="{{heading}}" transition="core-transition -right" class="scrolling pane" layered="false">
	raymes 2015/01/23 00:16:46 Can we make the id "paper-dialog"? Can we make the id "paper-dialog"? Alexandre Carlton 2015/01/23 00:25:11 Polymer allows access to internal elements through Show quoted text On 2015/01/23 00:16:46, raymes wrote: > Can we make the id "paper-dialog"? Polymer allows access to internal elements through "this.$.<id>" (see pdf-pane.js). Having a hyphen would force us to use "this.$['<id>']", which I'd rather avoid. Would "dialog" be a better id?
	9 <hr>

	10 <div id="reset-content">

	11 <content></content>

	12 </div>

	13 </paper-dialog>

	14 </template>

	15 <script src="pdf-pane.js"></script>

	16 </polymer-element>

OLD	NEW