Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 864733002: X87: fix debug checks for api callbacks returning symbols (Closed)

Created:
5 years, 11 months ago by chunyang.dai
Modified:
5 years, 11 months ago
Reviewers:
Weiliang, dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: fix debug checks for api callbacks returning symbols port 3eb589976a979fa80f0934a3754ebc79d289b713. original commit message: fix debug checks for api callbacks returning symbols BUG= R=weiliang.lin@intel.com Committed: https://crrev.com/4a62f245aed31de0f2a93456294aad36cf7e0baf Cr-Commit-Position: refs/heads/master@{#26176}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/x87/macro-assembler-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
chunyang.dai
PTAL.
5 years, 11 months ago (2015-01-21 05:17:43 UTC) #2
Weiliang
lgtm
5 years, 11 months ago (2015-01-21 05:21:48 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4a62f245aed31de0f2a93456294aad36cf7e0baf Cr-Commit-Position: refs/heads/master@{#26176}
5 years, 11 months ago (2015-01-21 05:26:15 UTC) #4
chunyang.dai
5 years, 11 months ago (2015-01-21 05:26:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4a62f245aed31de0f2a93456294aad36cf7e0baf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698