Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: src/x87/macro-assembler-x87.cc

Issue 864733002: X87: fix debug checks for api callbacks returning symbols (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X87 7 #if V8_TARGET_ARCH_X87
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/base/division-by-constant.h" 10 #include "src/base/division-by-constant.h"
(...skipping 2135 matching lines...) Expand 10 before | Expand all | Expand 10 after
2146 2146
2147 #if DEBUG 2147 #if DEBUG
2148 // Check if the function returned a valid JavaScript value. 2148 // Check if the function returned a valid JavaScript value.
2149 Label ok; 2149 Label ok;
2150 Register return_value = eax; 2150 Register return_value = eax;
2151 Register map = ecx; 2151 Register map = ecx;
2152 2152
2153 JumpIfSmi(return_value, &ok, Label::kNear); 2153 JumpIfSmi(return_value, &ok, Label::kNear);
2154 mov(map, FieldOperand(return_value, HeapObject::kMapOffset)); 2154 mov(map, FieldOperand(return_value, HeapObject::kMapOffset));
2155 2155
2156 CmpInstanceType(map, FIRST_NONSTRING_TYPE); 2156 CmpInstanceType(map, LAST_NAME_TYPE);
2157 j(below, &ok, Label::kNear); 2157 j(below_equal, &ok, Label::kNear);
2158 2158
2159 CmpInstanceType(map, FIRST_SPEC_OBJECT_TYPE); 2159 CmpInstanceType(map, FIRST_SPEC_OBJECT_TYPE);
2160 j(above_equal, &ok, Label::kNear); 2160 j(above_equal, &ok, Label::kNear);
2161 2161
2162 cmp(map, isolate()->factory()->heap_number_map()); 2162 cmp(map, isolate()->factory()->heap_number_map());
2163 j(equal, &ok, Label::kNear); 2163 j(equal, &ok, Label::kNear);
2164 2164
2165 cmp(return_value, isolate()->factory()->undefined_value()); 2165 cmp(return_value, isolate()->factory()->undefined_value());
2166 j(equal, &ok, Label::kNear); 2166 j(equal, &ok, Label::kNear);
2167 2167
(...skipping 1204 matching lines...) Expand 10 before | Expand all | Expand 10 after
3372 if (mag.shift > 0) sar(edx, mag.shift); 3372 if (mag.shift > 0) sar(edx, mag.shift);
3373 mov(eax, dividend); 3373 mov(eax, dividend);
3374 shr(eax, 31); 3374 shr(eax, 31);
3375 add(edx, eax); 3375 add(edx, eax);
3376 } 3376 }
3377 3377
3378 3378
3379 } } // namespace v8::internal 3379 } } // namespace v8::internal
3380 3380
3381 #endif // V8_TARGET_ARCH_X87 3381 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698