Made blink gyps and gns to public oilpan configuration

Made blink gyps and gns to public oilpan configuration

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189560

[tasak, 2015-01-23 13:06:08]

Patchset #2 (id:20001) has been deleted

[tasak, 2015-01-23 13:09:44]

Patchset #2 (id:40001) has been deleted

[tasak, 2015-01-23 13:16:18]

tasak@google.com changed reviewers:
+ brettw@chromium.org

[tasak, 2015-01-23 13:16:19]

Would you review this CL?

[brettw, 2015-01-26 19:30:06]

lgtm

https://codereview.chromium.org/864723003/diff/60001/public/BUILD.gn
File public/BUILD.gn (right):

https://codereview.chromium.org/864723003/diff/60001/public/BUILD.gn#newcode47
public/BUILD.gn:47: group("all_blink") {
I think you want to add it to this one also.

https://codereview.chromium.org/864723003/diff/60001/public/BUILD.gn#newcode103
public/BUILD.gn:103: source_set("blink_headers") {
And this one since the blink headers will need this.

https://codereview.chromium.org/864723003/diff/60001/public/features.gni
File public/features.gni (right):

https://codereview.chromium.org/864723003/diff/60001/public/features.gni#newc...
public/features.gni:10: public_feature_defines_list = []
Can you move this to config.gni? External code should use this file to depend on
the build flag, and should use depending on a wblink target to get the c++
flags. There shouldn't be need to get the defines another way

[tasak, 2015-01-27 06:42:30]

Thank you for review!

https://codereview.chromium.org/864723003/diff/60001/public/BUILD.gn
File public/BUILD.gn (right):

https://codereview.chromium.org/864723003/diff/60001/public/BUILD.gn#newcode47
public/BUILD.gn:47: group("all_blink") {
On 2015/01/26 19:30:06, brettw wrote:
> I think you want to add it to this one also.

Done.

https://codereview.chromium.org/864723003/diff/60001/public/BUILD.gn#newcode103
public/BUILD.gn:103: source_set("blink_headers") {
On 2015/01/26 19:30:06, brettw wrote:
> And this one since the blink headers will need this.

Done.

https://codereview.chromium.org/864723003/diff/60001/public/features.gni
File public/features.gni (right):

https://codereview.chromium.org/864723003/diff/60001/public/features.gni#newc...
public/features.gni:10: public_feature_defines_list = []
On 2015/01/26 19:30:06, brettw wrote:
> Can you move this to config.gni? External code should use this file to depend
on
> the build flag, and should use depending on a wblink target to get the c++
> flags. There shouldn't be need to get the defines another way

I see.
Done.

[tasak, 2015-01-27 06:43:33]

tasak@google.com changed reviewers:
+ jochen@chromium.org

[tasak, 2015-01-27 06:43:34]

jochen, would you review this CL?

I need this patch for https://codereview.chromium.org/800543006/.

[tasak, 2015-01-29 07:50:37]

On 2015/01/27 06:43:34, tasak wrote:
> jochen, would you review this CL?
> 
> I need this patch for https://codereview.chromium.org/800543006/.

jochen, would you review this CL?

[jochen (gone - plz use gerrit), 2015-01-29 15:21:25]

https://codereview.chromium.org/864723003/diff/80001/public/all.gyp
File public/all.gyp (right):

https://codereview.chromium.org/864723003/diff/80001/public/all.gyp#newcode46
public/all.gyp:46: 'include_dirs': [ '..' ],
why do you need this change for GYP but not in GN?

[tasak, 2015-02-03 06:40:26]

Thank you for review.

https://codereview.chromium.org/864723003/diff/80001/public/all.gyp
File public/all.gyp (right):

https://codereview.chromium.org/864723003/diff/80001/public/all.gyp#newcode46
public/all.gyp:46: 'include_dirs': [ '..' ],
On 2015/01/29 15:21:25, jochen (slow) wrote:
> why do you need this change for GYP but not in GN?

Yeah, we don't need this.
Done.

[jochen (gone - plz use gerrit), 2015-02-04 12:39:49]

lgtm

[tasak, 2015-02-05 02:25:55]

On 2015/02/04 12:39:49, jochen (slow) wrote:
> lgtm

Thank you.

[tasak, 2015-02-05 03:20:49]

New patchsets have been uploaded after l-g-t-m from jochen@chromium.org

[tasak, 2015-02-05 03:21:00]

The CQ bit was checked by tasak@google.com

[commit-bot: I haz the power, 2015-02-05 03:22:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/864723003/120001

[commit-bot: I haz the power, 2015-02-05 03:29:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-05 03:29:13]

Try jobs failed on following builders:
  android_blink_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)

[tasak, 2015-02-05 07:30:42]

The CQ bit was checked by tasak@google.com

[commit-bot: I haz the power, 2015-02-05 07:31:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/864723003/140001

[commit-bot: I haz the power, 2015-02-05 15:12:40]

Committed patchset #6 (id:140001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189560