public/features.gni - Issue 864723003: Made blink gyps and gns to public oilpan configuration

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: public/features.gni

Issue 864723003: Made blink gyps and gns to public oilpan configuration (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 declare_args() {	5 declare_args() {

6 # Enables the Oilpan garbage-collection infrastructure.	6 # Enables the Oilpan garbage-collection infrastructure.

7 enable_oilpan = false	7 enable_oilpan = false

8 }	8 }

	9

	10 public_feature_defines_list = []
	brettw 2015/01/26 19:30:06 Can you move this to config.gni? External code sho Can you move this to config.gni? External code should use this file to depend on the build flag, and should use depending on a wblink target to get the c++ flags. There shouldn't be need to get the defines another way tasak 2015/01/27 06:42:30 I see. Done. Show quoted text On 2015/01/26 19:30:06, brettw wrote: > Can you move this to config.gni? External code should use this file to depend on > the build flag, and should use depending on a wblink target to get the c++ > flags. There shouldn't be need to get the defines another way I see. Done.
	11

	12 if (enable_oilpan) {

	13 public_feature_defines_list += [ "ENABLE_OILPAN=1" ]

	14 }

OLD	NEW

« public/BUILD.gn ('K') | « public/blink.gyp ('k') | no next file » | no next file with comments »