Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 864533002: Fix template angle bracket syntax in modules (Closed)

Created:
5 years, 11 months ago by rwlbuis
Modified:
5 years, 11 months ago
Reviewers:
philipj_slow, Mike West
CC:
blink-reviews, tzik, eric.carlson_apple.com, dgrogan, jsbell+serviceworker_chromium.org, yhirano+watch_chromium.org, philipj_slow, nhiroki, Raymond Toy, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, timvolodine, jsbell+idb_chromium.org, michaeln, tyoshino+watch_chromium.org, mlamouri+watch-blink_chromium.org, serviceworker-reviews, falken, mvanouwerkerk+watch_chromium.org, kinuko+serviceworker, cmumford, horo+watch_chromium.org, kinuko+fileapi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix template angle bracket syntax in modules In C++11 the parser is able to parse >> as the end of the template argument list. BUG=449681 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188709

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -218 lines) Patch
M Source/modules/accessibility/AXListBoxOption.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXMenuListPopup.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXNodeObject.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/accessibility/AXNodeObject.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/modules/accessibility/AXObject.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXObjectCacheImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/accessibility/AXObjectCacheImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/accessibility/AXRenderObject.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeys.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeys.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/fetch/BodyStreamBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/fetch/FetchHeaderList.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/fetch/FetchManager.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/fetch/FetchManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/fetch/Headers.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/fetch/Headers.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/fetch/RequestInit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/fetch/ResponseInit.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/DOMFileSystem.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/filesystem/DirectoryReaderSync.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/EntriesCallback.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/FileSystemCallbacks.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/InspectorFileSystemAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/filesystem/SyncCallbackHelper.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/gamepad/GamepadButton.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/gamepad/NavigatorGamepad.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/geofencing/Geofencing.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/geolocation/Geolocation.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/geolocation/GeolocationController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/geolocation/GeolocationController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/geolocation/GeolocationWatchers.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/geolocation/GeolocationWatchers.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/geolocation/testing/GeolocationClientMock.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBDatabase.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBEventDispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBEventDispatcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBKey.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBObjectStore.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBRequest.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/indexeddb/IDBRequest.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/indexeddb/IDBTransaction.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/indexeddb/IDBTransaction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBTransactionTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/InspectorIndexedDBAgent.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/indexeddb/WebIDBCallbacksImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediasource/MediaSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/MediaSourceRegistry.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/MediaSourceRegistry.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/MediaDeviceInfo.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/MediaStream.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/MediaStream.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/MediaStreamRegistry.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/MediaStreamTrack.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/MediaStreamTrack.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCDTMFSender.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/RTCDTMFSender.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCDataChannel.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/RTCDataChannel.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/mediastream/RTCStatsResponse.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/SourceInfo.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/screen_orientation/ScreenOrientationController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/Cache.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/CacheStorage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/CacheTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerClients.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechGrammarList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognition.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechRecognition.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognitionEvent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionResult.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionResult.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionResultList.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionResultList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechSynthesis.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/speech/SpeechSynthesis.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webaudio/AudioBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioContext.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/webaudio/AudioListener.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioNode.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webaudio/AudioNodeOutput.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webaudio/PeriodicWave.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/ScriptProcessorNode.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/Database.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseManager.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseThread.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseThread.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/webdatabase/InspectorDatabaseAgent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/InspectorDatabaseAgent.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webdatabase/SQLStatementBackend.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/SQLTransactionBackend.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/SQLTransactionBackend.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/SQLTransactionCoordinator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webmidi/MIDIAccess.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webmidi/MIDIAccess.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/webmidi/MIDIInputMap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIInputMap.cpp View 1 chunk +1 line, -1 line 2 comments Download
M Source/modules/webmidi/MIDIOutputMap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIOutputMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIPortMap.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/websockets/DOMWebSocket.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/websockets/DOMWebSocket.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/websockets/DOMWebSocketTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/websockets/DocumentWebSocketChannel.h View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/websockets/DocumentWebSocketChannel.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/websockets/DocumentWebSocketChannelTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/websockets/WebSocketChannel.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WebSocketChannelClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WorkerWebSocketChannel.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/websockets/WorkerWebSocketChannel.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
rwlbuis
PTAL. Sorry about the patch size :]
5 years, 11 months ago (2015-01-20 19:20:06 UTC) #2
philipj_slow
lgtm https://codereview.chromium.org/864533002/diff/1/Source/modules/webmidi/MIDIInputMap.cpp File Source/modules/webmidi/MIDIInputMap.cpp (right): https://codereview.chromium.org/864533002/diff/1/Source/modules/webmidi/MIDIInputMap.cpp#newcode13 Source/modules/webmidi/MIDIInputMap.cpp:13: MIDIInputMap::MIDIInputMap(const HeapHashMap<String, Member<MIDIInput>> map) I took a look ...
5 years, 11 months ago (2015-01-20 21:03:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864533002/1
5 years, 11 months ago (2015-01-20 21:04:33 UTC) #6
rwlbuis
https://codereview.chromium.org/864533002/diff/1/Source/modules/webmidi/MIDIInputMap.cpp File Source/modules/webmidi/MIDIInputMap.cpp (right): https://codereview.chromium.org/864533002/diff/1/Source/modules/webmidi/MIDIInputMap.cpp#newcode13 Source/modules/webmidi/MIDIInputMap.cpp:13: MIDIInputMap::MIDIInputMap(const HeapHashMap<String, Member<MIDIInput>> map) On 2015/01/20 21:03:27, philipj wrote: ...
5 years, 11 months ago (2015-01-20 22:56:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864533002/1
5 years, 11 months ago (2015-01-21 00:55:21 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 04:55:28 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188709

Powered by Google App Engine
This is Rietveld 408576698