Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: src/compiler/graph-visualizer.cc

Issue 864293002: [turbofan] Cleanup Schedule and related classes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/graph-visualizer.cc
diff --git a/src/compiler/graph-visualizer.cc b/src/compiler/graph-visualizer.cc
index 0bad333d842c00c5860e4f448a80845e5e53d0e7..72e0aebdf8c281729c8b9992185c3df68be4c4d0 100644
--- a/src/compiler/graph-visualizer.cc
+++ b/src/compiler/graph-visualizer.cc
@@ -570,17 +570,15 @@ void GraphC1Visualizer::PrintSchedule(const char* phase,
PrintIndent();
os_ << "predecessors";
- for (BasicBlock::Predecessors::iterator j = current->predecessors_begin();
- j != current->predecessors_end(); ++j) {
- os_ << " \"B" << (*j)->id() << "\"";
+ for (auto predecessor : current->predecessors()) {
Michael Starzinger 2015/01/22 12:15:29 remark: I know you all like the "auto" magic, but
Benedikt Meurer 2015/01/22 13:48:01 Done.
+ os_ << " \"B" << predecessor->id() << "\"";
}
os_ << "\n";
PrintIndent();
os_ << "successors";
- for (BasicBlock::Successors::iterator j = current->successors_begin();
- j != current->successors_end(); ++j) {
- os_ << " \"B" << (*j)->id() << "\"";
+ for (auto successor : current->successors()) {
+ os_ << " \"B" << successor->id() << "\"";
}
os_ << "\n";
@@ -665,9 +663,8 @@ void GraphC1Visualizer::PrintSchedule(const char* phase,
os_ << -1 - current->id().ToInt() << " Goto";
}
os_ << " ->";
- for (BasicBlock::Successors::iterator j = current->successors_begin();
- j != current->successors_end(); ++j) {
- os_ << " B" << (*j)->id();
+ for (auto successor : current->successors()) {
+ os_ << " B" << successor->id();
}
if (FLAG_trace_turbo_types && current->control_input() != NULL) {
os_ << " ";

Powered by Google App Engine
This is Rietveld 408576698