[turbofan] Cleanup Schedule and related classes.

src/compiler/graph-visualizer.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/graph-visualizer.h"
 
 #include <sstream>
 #include <string>
 
 #include "src/code-stubs.h"
@@ skipping 552 matching lines @@
   const BasicBlockVector* rpo = schedule->rpo_order();
   for (size_t i = 0; i < rpo->size(); i++) {
     BasicBlock* current = (*rpo)[i];
     Tag block_tag(this, "block");
     PrintBlockProperty("name", current->id());
     PrintIntProperty("from_bci", -1);
     PrintIntProperty("to_bci", -1);
 
     PrintIndent();
     os_ << "predecessors";
-    for (BasicBlock::Predecessors::iterator j = current->predecessors_begin();
-         j != current->predecessors_end(); ++j) {
-      os_ << " \"B" << (*j)->id() << "\"";
+    for (auto predecessor : current->predecessors()) {

[Michael Starzinger, 2015/01/22 12:15:29]

remark: I know you all like the "auto" magic, but I would find "BasicBlock
predecessor" more readable. Just putting it out there, feel free to ignore me in
this regard. :)

[Benedikt Meurer, 2015/01/22 13:48:01]

Done.

+      os_ << " \"B" << predecessor->id() << "\"";
     }
     os_ << "\n";
 
     PrintIndent();
     os_ << "successors";
-    for (BasicBlock::Successors::iterator j = current->successors_begin();
-         j != current->successors_end(); ++j) {
-      os_ << " \"B" << (*j)->id() << "\"";
+    for (auto successor : current->successors()) {
+      os_ << " \"B" << successor->id() << "\"";
     }
     os_ << "\n";
 
     PrintIndent();
     os_ << "xhandlers\n";
 
     PrintIndent();
     os_ << "flags\n";
 
     if (current->dominator() != NULL) {
@@ skipping 64 matching lines @@
       BasicBlock::Control control = current->control();
       if (control != BasicBlock::kNone) {
         PrintIndent();
         os_ << "0 0 ";
         if (current->control_input() != NULL) {
           PrintNode(current->control_input());
         } else {
           os_ << -1 - current->id().ToInt() << " Goto";
         }
         os_ << " ->";
-        for (BasicBlock::Successors::iterator j = current->successors_begin();
-             j != current->successors_end(); ++j) {
-          os_ << " B" << (*j)->id();
+        for (auto successor : current->successors()) {
+          os_ << " B" << successor->id();
         }
         if (FLAG_trace_turbo_types && current->control_input() != NULL) {
           os_ << " ";
           PrintType(current->control_input());
         }
         os_ << " <|@\n";
       }
     }
 
     if (instructions != NULL) {
@@ skipping 143 matching lines @@
         os << "#" << SafeId(i) << ":" << SafeMnemonic(i);
       }
       os << ")" << std::endl;
     }
   }
   return os;
 }
 }
 }
 }  // namespace v8::internal::compiler