Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 864163003: Rename base::Process::pid() to Pid() (Closed)

Created:
5 years, 11 months ago by rvargas (doing something else)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, James Su, nkostylev+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, erikwright+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename base::Process::pid() to Pid() The method is not a simple accessor. BUG=417532 TBR=satorux@chromium.org (chromeos) TBR=siggi@chromium.org (browser_watcher) TBR=mseaborn@chromium.org (nacl) TBR=davidben@chromium.org (content) TBR=rsesek@chromium.org (sandbox) TBR=sadrul@chromium.org (ui) Committed: https://crrev.com/960db8860336db15dbdbe71ebbff318833697f81 Cr-Commit-Position: refs/heads/master@{#312978}

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -42 lines) Patch
M base/process/kill_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/kill_posix.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/process/process.h View 1 chunk +1 line, -1 line 0 comments Download
M base/process/process_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/process_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/process/process_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/process_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/input_device_settings_impl_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system_logs/debug_log_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/platform_util_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/printer_manager_dialog_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/printing_layout_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/process_info_snapshot_mac_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/advanced_options_utils_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/process_proxy/process_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_watcher/exit_code_watcher_win.cc View 3 chunks +8 lines, -3 lines 2 comments Download
M components/browser_watcher/exit_code_watcher_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/nacl/common/nacl_debug_exception_handler_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/child_process_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/zygote_host/zygote_host_impl_linux.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/public/browser/browser_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/mac/bootstrap_sandbox_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M sandbox/mac/xpc_message_server_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/chromeos/ime_keyboard_x11.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (4 generated)
rvargas (doing something else)
Lei, PTAL
5 years, 11 months ago (2015-01-23 23:27:08 UTC) #4
Lei Zhang
https://chromiumcodereview.appspot.com/864163003/diff/40001/components/browser_watcher/exit_code_watcher_win.cc File components/browser_watcher/exit_code_watcher_win.cc (right): https://chromiumcodereview.appspot.com/864163003/diff/40001/components/browser_watcher/exit_code_watcher_win.cc#newcode39 components/browser_watcher/exit_code_watcher_win.cc:39: if (process_pid == 0) { Is this possible when ...
5 years, 11 months ago (2015-01-23 23:53:44 UTC) #5
rvargas (doing something else)
https://chromiumcodereview.appspot.com/864163003/diff/40001/components/browser_watcher/exit_code_watcher_win.cc File components/browser_watcher/exit_code_watcher_win.cc (right): https://chromiumcodereview.appspot.com/864163003/diff/40001/components/browser_watcher/exit_code_watcher_win.cc#newcode39 components/browser_watcher/exit_code_watcher_win.cc:39: if (process_pid == 0) { On 2015/01/23 23:53:44, Lei ...
5 years, 11 months ago (2015-01-23 23:55:56 UTC) #6
Robert Sesek
sandbox/mac/ LGTM
5 years, 11 months ago (2015-01-24 00:07:05 UTC) #7
Lei Zhang
lgtm
5 years, 11 months ago (2015-01-24 00:13:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864163003/40001
5 years, 11 months ago (2015-01-24 00:16:09 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 11 months ago (2015-01-24 00:27:53 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/960db8860336db15dbdbe71ebbff318833697f81 Cr-Commit-Position: refs/heads/master@{#312978}
5 years, 11 months ago (2015-01-24 00:30:03 UTC) #12
Mark Seaborn
LGTM for nacl, for the record.
5 years, 11 months ago (2015-01-26 19:44:05 UTC) #13
davidben
(content lgtm)
5 years, 11 months ago (2015-01-26 19:55:35 UTC) #14
satorux1
5 years, 11 months ago (2015-01-27 06:56:40 UTC) #15
Message was sent while issue was closed. 
c/b/chromeos lgtm for the  record

Powered by Google App Engine
This is Rietveld 408576698