chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc - Issue 864163003: Rename base::Process::pid() to Pid()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

Issue 864163003: Rename base::Process::pid() to Pid() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/process_info_snapshot_mac_unittest.cc ('k') | chrome/browser/ui/webui/options/advanced_options_utils_linux.cc » ('j') | components/browser_watcher/exit_code_watcher_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

diff --git a/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc b/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

index 27d0c7730ff2134707f99dd3a25b2552e7179343..5dd215a711371044f1b0c7e73109ca44b1403dfd 100644

--- a/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

+++ b/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

@@ -321,7 +321,7 @@ IN_PROC_BROWSER_TEST_F(ChromeRenderProcessHostTest, MAYBE_Backgrounding) {

GURL page2("data:text/html,hello world2");

base::Process process2 = ShowSingletonTab(page2);

ASSERT_TRUE(process2.IsValid());

- EXPECT_NE(process1.pid(), process2.pid());

+ EXPECT_NE(process1.Pid(), process2.Pid());

EXPECT_TRUE(process1.IsProcessBackgrounded());

EXPECT_FALSE(process2.IsProcessBackgrounded());

@@ -330,15 +330,15 @@ IN_PROC_BROWSER_TEST_F(ChromeRenderProcessHostTest, MAYBE_Backgrounding) {

GURL page3("data:text/html,hello world3");

base::Process process3 = OpenBackgroundTab(page3);

ASSERT_TRUE(process3.IsValid());

- EXPECT_NE(process3.pid(), process1.pid());

- EXPECT_NE(process3.pid(), process2.pid());

+ EXPECT_NE(process3.Pid(), process1.Pid());

+ EXPECT_NE(process3.Pid(), process2.Pid());

EXPECT_TRUE(process1.IsProcessBackgrounded());

EXPECT_FALSE(process2.IsProcessBackgrounded());

EXPECT_TRUE(process3.IsProcessBackgrounded());

// Navigate back to the first page. Its renderer should be in foreground

// again while the other renderers should be backgrounded.

- EXPECT_EQ(process1.pid(), ShowSingletonTab(page1).pid());

+ EXPECT_EQ(process1.Pid(), ShowSingletonTab(page1).Pid());

EXPECT_FALSE(process1.IsProcessBackgrounded());

EXPECT_TRUE(process2.IsProcessBackgrounded());

EXPECT_TRUE(process3.IsProcessBackgrounded());