Move sandboxed_unpacker.{h,cc} from chrome/ to extensions/

Move sandboxed_unpacker.{h,cc} from chrome/ to extensions/

This is a mostly mechanical change to move these files over, and
make corresponding changes to strings, build files, and include paths.

BUG=447014
Committed: https://crrev.com/275faaaa9d7ceadaa660e113a3a799b942c1e297
Cr-Commit-Position: refs/heads/master@{#313404}

[asargent_no_longer_on_chrome, 2015-01-21 21:41:54]

asargent@chromium.org changed reviewers:
+ yoz@chromium.org

[asargent_no_longer_on_chrome, 2015-01-21 21:41:56]

https://codereview.chromium.org/864093002/diff/1/chrome/browser/extensions/cr...
File chrome/browser/extensions/crx_installer.h (left):

https://codereview.chromium.org/864093002/diff/1/chrome/browser/extensions/cr...
chrome/browser/extensions/crx_installer.h:16: #include
"chrome/browser/extensions/blacklist.h"
Removing this include is unrelated to the rest of the CL, but I noticed it was
unused so I figured I'd kill it while I was in here.

https://codereview.chromium.org/864093002/diff/1/chrome/utility/chrome_conten...
File chrome/utility/chrome_content_utility_client.cc (right):

https://codereview.chromium.org/864093002/diff/1/chrome/utility/chrome_conten...
chrome/utility/chrome_content_utility_client.cc:112:
extensions::UtilityHandler::UtilityThreadStarted();
Note: this change just cuts out the middleman, since
ExtensionsHandler::UtilityThreadStarted didn't do anything interesting - all it
did was just call extensions::UtilityHandler::UtilityThreadStarted. So I figured
we could just do that directly here and get rid of
ExtensionsHandler::UtilityThreadStarted, and if some day we actually did need to
do some chrome-specific work in it, we can always bring it back.

https://codereview.chromium.org/864093002/diff/1/chrome/utility/extensions/ex...
File chrome/utility/extensions/extensions_handler.cc (right):

https://codereview.chromium.org/864093002/diff/1/chrome/utility/extensions/ex...
chrome/utility/extensions/extensions_handler.cc:61:
ExtensionsClient::Set(ChromeExtensionsClient::GetInstance());
Note that we used to only do this inside OnUnpackExtension which got moved out
to extensions::UtilityHandler.

I guess we didn't happen to need an ExtensionsClient for the work that happens
in any of the other message handlers here, but it should not hurt to have one
registered either.

[Yoyo Zhou, 2015-01-22 02:06:25]

LGTM

https://codereview.chromium.org/864093002/diff/20001/extensions/browser/exten...
File extensions/browser/extensions_test.h (right):

https://codereview.chromium.org/864093002/diff/20001/extensions/browser/exten...
extensions/browser/extensions_test.h:53:
scoped_ptr<content::ContentUtilityClient> utility_content_client_;
content_utility_client_

[asargent_no_longer_on_chrome, 2015-01-22 23:02:50]

https://codereview.chromium.org/864093002/diff/20001/extensions/browser/exten...
File extensions/browser/extensions_test.h (right):

https://codereview.chromium.org/864093002/diff/20001/extensions/browser/exten...
extensions/browser/extensions_test.h:53:
scoped_ptr<content::ContentUtilityClient> utility_content_client_;
On 2015/01/22 02:06:25, Yoyo Zhou wrote:
> content_utility_client_

Done.

I also noticed I wasn't calling content::SetUtilityClientForTesting(NULL) in the
destructor in the .cc file, like we do for some of the other content:: static
setter stuff, so I have added that.

[asargent_no_longer_on_chrome, 2015-01-22 23:10:28]

asargent@chromium.org changed reviewers:
+ isherman@chromium.org, jschuh@chromium.org, sky@chromium.org

[asargent_no_longer_on_chrome, 2015-01-22 23:10:28]

Reviewers, please look at the following:

sky : chrome/utility/chrome_content_utility_client.cc

jschuh : (mechanical move of IPC messages from one file to another)
 chrome/common/extensions/chrome_utility_extensions_messages.h
 extensions/common/extension_utility_messages.h


isherman : tools/metrics/histograms/histograms.xml

(the code logging this new histogram entry was already in sandboxed_unpacker.cc
which I'm moving over, but this particular histogram wasn't listed in the
histograms.xml file)


Thanks!

[Ilya Sherman, 2015-01-22 23:15:36]

histograms lgtm % nits:

https://codereview.chromium.org/864093002/diff/40001/tools/metrics/histograms...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/864093002/diff/40001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:8975: +<histogram
name="Extensions.SandboxUnpackSuccessCrxSize">
nit: Please add a units attribute.

https://codereview.chromium.org/864093002/diff/40001/tools/metrics/histograms...
tools/metrics/histograms/histograms.xml:8977: +  <summary>Size of the .crx file,
in KB, when the unpack succeeds.</summary>
nit: It might help to be super explicit as to whether the size being measured
here is the compressed or the uncompressed size.

[jschuh, 2015-01-22 23:31:40]

ipc security lgtm (notes: mechanical change)

[sky, 2015-01-23 00:41:42]

chrome/utility/chrome_content_utility_client.cc LGTM

[asargent_no_longer_on_chrome, 2015-01-27 21:10:57]

+cc dpolukhin as TBR for changes in 

chrome/browser/chromeos/app_mode/kiosk_external_update_validator.h
chrome/browser/chromeos/app_mode/kiosk_external_updater.cc

where I'm just updating #include paths

[asargent_no_longer_on_chrome, 2015-01-27 21:11:08]

The CQ bit was checked by asargent@chromium.org

[commit-bot: I haz the power, 2015-01-27 21:12:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/864093002/60001

[commit-bot: I haz the power, 2015-01-27 21:31:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-27 21:31:10]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[asargent_no_longer_on_chrome, 2015-01-27 22:43:00]

The CQ bit was checked by asargent@chromium.org

[commit-bot: I haz the power, 2015-01-27 22:44:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/864093002/80001

[commit-bot: I haz the power, 2015-01-27 23:44:00]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-01-27 23:45:16]

Patchset 5 (id:??) landed as
https://crrev.com/275faaaa9d7ceadaa660e113a3a799b942c1e297
Cr-Commit-Position: refs/heads/master@{#313404}