Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Side by Side Diff: chrome/browser/extensions/sandboxed_unpacker_unittest.cc

Issue 864093002: Move sandboxed_unpacker.{h,cc} from chrome/ to extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix compile errors Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/bind.h"
6 #include "base/files/file_util.h"
7 #include "base/memory/ref_counted.h"
8 #include "base/message_loop/message_loop.h"
9 #include "base/path_service.h"
10 #include "base/run_loop.h"
11 #include "base/strings/string_util.h"
12 #include "base/values.h"
13 #include "chrome/browser/extensions/sandboxed_unpacker.h"
14 #include "chrome/common/chrome_paths.h"
15 #include "content/public/test/test_browser_thread_bundle.h"
16 #include "content/public/test/test_utils.h"
17 #include "extensions/common/constants.h"
18 #include "extensions/common/extension.h"
19 #include "extensions/common/extension_paths.h"
20 #include "testing/gtest/include/gtest/gtest.h"
21 #include "third_party/skia/include/core/SkBitmap.h"
22
23 namespace extensions {
24
25 class MockSandboxedUnpackerClient : public SandboxedUnpackerClient {
26 public:
27
28 void WaitForUnpack() {
29 scoped_refptr<content::MessageLoopRunner> runner =
30 new content::MessageLoopRunner;
31 quit_closure_ = runner->QuitClosure();
32 runner->Run();
33 }
34
35 base::FilePath temp_dir() const { return temp_dir_; }
36
37 private:
38 ~MockSandboxedUnpackerClient() override {}
39
40 void OnUnpackSuccess(const base::FilePath& temp_dir,
41 const base::FilePath& extension_root,
42 const base::DictionaryValue* original_manifest,
43 const Extension* extension,
44 const SkBitmap& install_icon) override {
45 temp_dir_ = temp_dir;
46 quit_closure_.Run();
47
48 }
49
50 void OnUnpackFailure(const base::string16& error) override {
51 ASSERT_TRUE(false);
52 }
53
54 base::Closure quit_closure_;
55 base::FilePath temp_dir_;
56 };
57
58 class SandboxedUnpackerTest : public testing::Test {
59 public:
60 void SetUp() override {
61 ASSERT_TRUE(extensions_dir_.CreateUniqueTempDir());
62 browser_threads_.reset(new content::TestBrowserThreadBundle(
63 content::TestBrowserThreadBundle::IO_MAINLOOP));
64 in_process_utility_thread_helper_.reset(
65 new content::InProcessUtilityThreadHelper);
66 // It will delete itself.
67 client_ = new MockSandboxedUnpackerClient;
68 }
69
70 void TearDown() override {
71 // Need to destruct SandboxedUnpacker before the message loop since
72 // it posts a task to it.
73 sandboxed_unpacker_ = NULL;
74 base::RunLoop().RunUntilIdle();
75 }
76
77 void SetupUnpacker(const std::string& crx_name) {
78 base::FilePath original_path;
79 ASSERT_TRUE(PathService::Get(extensions::DIR_TEST_DATA, &original_path));
80 original_path = original_path.AppendASCII("unpacker").AppendASCII(crx_name);
81 ASSERT_TRUE(base::PathExists(original_path)) << original_path.value();
82
83 sandboxed_unpacker_ = new SandboxedUnpacker(
84 original_path,
85 Manifest::INTERNAL,
86 Extension::NO_FLAGS,
87 extensions_dir_.path(),
88 base::MessageLoopProxy::current(),
89 client_);
90
91 base::MessageLoopProxy::current()->PostTask(
92 FROM_HERE,
93 base::Bind(&SandboxedUnpacker::Start, sandboxed_unpacker_.get()));
94 client_->WaitForUnpack();
95 }
96
97 base::FilePath GetInstallPath() {
98 return client_->temp_dir().AppendASCII(kTempExtensionName);
99 }
100
101 protected:
102 base::ScopedTempDir extensions_dir_;
103 MockSandboxedUnpackerClient* client_;
104 scoped_refptr<SandboxedUnpacker> sandboxed_unpacker_;
105 scoped_ptr<content::TestBrowserThreadBundle> browser_threads_;
106 scoped_ptr<content::InProcessUtilityThreadHelper>
107 in_process_utility_thread_helper_;
108 };
109
110 TEST_F(SandboxedUnpackerTest, NoCatalogsSuccess) {
111 SetupUnpacker("no_l10n.crx");
112 // Check that there is no _locales folder.
113 base::FilePath install_path =
114 GetInstallPath().Append(kLocaleFolder);
115 EXPECT_FALSE(base::PathExists(install_path));
116 }
117
118 TEST_F(SandboxedUnpackerTest, WithCatalogsSuccess) {
119 SetupUnpacker("good_l10n.crx");
120 // Check that there is _locales folder.
121 base::FilePath install_path =
122 GetInstallPath().Append(kLocaleFolder);
123 EXPECT_TRUE(base::PathExists(install_path));
124 }
125
126 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/sandboxed_unpacker.cc ('k') | chrome/browser/extensions/startup_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698