Setup Android framework builds to use the appropriate shared lib defines.

Setup Android framework builds to use the appropriate shared lib defines.

Committed: https://skia.googlesource.com/skia/+/f379ad3429b61eb1d86e916767258340df372538

[djsollen, 2015-01-27 14:48:24]

djsollen@google.com changed reviewers:
+ scroggo@google.com

[scroggo, 2015-01-27 16:50:10]

lgtm

https://codereview.chromium.org/864043005/diff/1/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.chromium.org/864043005/diff/1/gyp/common_conditions.gypi#n...
gyp/common_conditions.gypi:358: # We can't use the skia_shared_library gyp
setting because we need to
FWIW, part of the problem is that our defines are placed directly into
SkUserConfig, which is included by anyone that uses our headers.

If we could instead used CFLAGS and EXPORT_CFLAGS properly (b/18240859), we
wouldn't need to be so tricky.

It also might be worth mentioning that this is defined in CFLAGS rather than
being included in 'defines' (like most of the rest of our defines) is due to how
we treat 'defines' specially.

[djsollen, 2015-01-27 16:54:39]

The CQ bit was checked by djsollen@google.com

[commit-bot: I haz the power, 2015-01-27 16:55:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/864043005/1

[commit-bot: I haz the power, 2015-01-27 17:01:05]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f379ad3429b61eb1d86e916767258340df372538