Setup Android framework builds to use the appropriate shared lib defines.

gyp/common_conditions.gypi

 # conditions used in both common.gypi and skia.gyp in chromium
 #
 {
   'defines': [
     'SK_ALLOW_STATIC_GLOBAL_INITIALIZERS=<(skia_static_initializers)',
     'SK_SUPPORT_GPU=<(skia_gpu)',
     'SK_SUPPORT_OPENCL=<(skia_opencl)',
     'SK_FORCE_DISTANCE_FIELD_TEXT=<(skia_force_distance_field_text)',
   ],
   'conditions' : [
@@ skipping 336 matching lines @@
       ],
       'cflags': [
         # Skia does not enforce this usage pattern so we disable it here to avoid
         # unecessary log spew when building
         '-Wno-unused-parameter',
 
         # Android's -D_FORTIFY_SOURCE=2 extensions are incompatibile with SkString.
         # Revert to -D_FORTIFY_SOURCE=1
         '-U_FORTIFY_SOURCE',
         '-D_FORTIFY_SOURCE=1',
+
+        # We can't use the skia_shared_library gyp setting because we need to

[scroggo, 2015/01/27 16:50:10]

FWIW, part of the problem is that our defines are placed directly into
SkUserConfig, which is included by anyone that uses our headers.

If we could instead used CFLAGS and EXPORT_CFLAGS properly (b/18240859), we
wouldn't need to be so tricky.

It also might be worth mentioning that this is defined in CFLAGS rather than
being included in 'defines' (like most of the rest of our defines) is due to how
we treat 'defines' specially.

+        # isolate this define to Skia sources. CFLAGS are local to Android.mk
+        # and ensures that this define is not exported to clients of the library
+        '-DSKIA_IMPLEMENTATION=1',
       ],
       # Remove flags which are either unnecessary or problematic for the
       # Android framework build. Many of these flags are removed simply because
       # they were not previously in the Android framework makefile, and we did
       # did not intend to add them when generating the makefile.
       # TODO (scroggo): Investigate whether any of these flags are actually
       # needed/would be beneficial.
       'cflags!': [
         # Android has one makefile, used for both debugging (after manual
         # modification) and release. Turn off debug info by default.
@@ skipping 25 matching lines @@
         # When built as part of the system image we can enable certian non-NDK
         # compliant optimizations.
         'SK_BUILD_FOR_ANDROID_FRAMEWORK',
         # Optimizations for chromium (m30)
         'GR_GL_CUSTOM_SETUP_HEADER "gl/GrGLConfig_chrome.h"',
         'IGNORE_ROT_AA_RECT_OPT',
         'SkLONGLONG int64_t',
         'SK_DEFAULT_FONT_CACHE_LIMIT   (768 * 1024)',
         'SK_DEFAULT_GLOBAL_DISCARDABLE_MEMORY_POOL_SIZE (512 * 1024)',
         'SK_IGNORE_ETC1_SUPPORT',
+        # We can't use the skia_shared_library gyp setting because we need expose
+        # this define globally and the the implemention define as a cflag.
+        'SKIA_DLL',
         # Defines from skia_for_android_framework_defines.gypi
         '<@(skia_for_android_framework_defines)',
       ],
     }],
 
     [ 'skia_os in ["linux", "freebsd", "openbsd", "solaris", "nacl", "chromeos"]',
       {
         'defines': [
           'SK_SAMPLES_FOR_X',
           'SK_BUILD_FOR_UNIX',
@@ skipping 234 matching lines @@
     [ 'skia_is_bot', {
       'defines': [ 'SK_CRASH_HANDLER' ],
     }],
 
   ], # end 'conditions'
   # The Xcode SYMROOT must be at the root. See build/common.gypi in chromium for more details
   'xcode_settings': {
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }