Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 864033002: Add missing FrameState to harmony class literals. (Closed)

Created:
5 years, 11 months ago by Michael Starzinger
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_deoptimization-test-get-proto
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add missing FrameState to harmony class literals. R=bmeurer@chromium.org TEST=mjsunit/harmony/classes Committed: https://crrev.com/62a49868b34738ad5ce2ef22814fc2308bb1c978 Cr-Commit-Position: refs/heads/master@{#26202}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M src/compiler/ast-graph-builder.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Michael Starzinger
5 years, 11 months ago (2015-01-21 17:15:01 UTC) #1
Michael Starzinger
Benedikt: PTAL. Dmitry: FYI.
5 years, 11 months ago (2015-01-21 18:00:26 UTC) #3
Dmitry Lomov (no reviews)
lgtm from my end but TF expert should look (thanks for adding me to these ...
5 years, 11 months ago (2015-01-21 18:00:54 UTC) #4
Benedikt Meurer
LGTM
5 years, 11 months ago (2015-01-21 18:34:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/864033002/1
5 years, 11 months ago (2015-01-21 18:35:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-21 18:46:56 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 18:47:08 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62a49868b34738ad5ce2ef22814fc2308bb1c978
Cr-Commit-Position: refs/heads/master@{#26202}

Powered by Google App Engine
This is Rietveld 408576698