Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 864033002: Add missing FrameState to harmony class literals. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_deoptimization-test-get-proto
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/linkage.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/ast-graph-builder.cc
diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc
index f2d0291f4b697c1b944adc31f23c512c6f5464a1..f001455c3eb1aa0631ca61713a3dcadbaf79f2e2 100644
--- a/src/compiler/ast-graph-builder.cc
+++ b/src/compiler/ast-graph-builder.cc
@@ -932,7 +932,9 @@ void AstGraphBuilder::VisitClassLiteralContents(ClassLiteral* expr) {
if (FunctionLiteral::NeedsHomeObject(property->value())) {
Unique<Name> name =
MakeUnique(isolate()->factory()->home_object_symbol());
- NewNode(javascript()->StoreNamed(strict_mode(), name), value, receiver);
+ Node* store = NewNode(javascript()->StoreNamed(strict_mode(), name),
+ value, receiver);
+ PrepareFrameState(store, BailoutId::None());
}
}
@@ -948,6 +950,7 @@ void AstGraphBuilder::VisitClassLiteralContents(ClassLiteral* expr) {
BuildVariableAssignment(var, literal, Token::INIT_CONST, BailoutId::None());
}
+ PrepareFrameState(literal, expr->id(), ast_context()->GetStateCombine());
ast_context()->ProduceValue(literal);
}
@@ -1461,11 +1464,12 @@ void AstGraphBuilder::VisitCall(Call* expr) {
flags = CALL_AS_METHOD;
break;
}
- case Call::SUPER_CALL: {
+ case Call::SUPER_CALL:
// TODO(dslomov): Implement super calls.
- UNIMPLEMENTED();
+ callee_value = jsgraph()->UndefinedConstant();
+ receiver_value = jsgraph()->UndefinedConstant();
+ SetStackOverflow();
break;
- }
case Call::POSSIBLY_EVAL_CALL:
possibly_eval = true;
// Fall through.
« no previous file with comments | « no previous file | src/compiler/linkage.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698