Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Issue 863883003: [Oilpan] Split sweep phase in tracing into two categories (Closed)

Created:
5 years, 11 months ago by peria
Modified:
5 years, 11 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split sweep into "Lazy sweep" and "Complete sweep" phases in about:tracing. This change is following http://crrev.com/758163004 BUG=None TEST=./tools/perf/run_tests help OilpanGCTimesTest --browser=release Committed: https://crrev.com/35f317c778c0c36d1d5df412a7f0a97cc3dfdb78 Cr-Commit-Position: refs/heads/master@{#312572}

Patch Set 1 #

Patch Set 2 : Add a metric of total time of sweeping #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -12 lines) Patch
M tools/perf/measurements/oilpan_gc_times.py View 1 4 chunks +33 lines, -12 lines 0 comments Download

Messages

Total messages: 16 (2 generated)
peria
PTL.
5 years, 11 months ago (2015-01-21 05:23:49 UTC) #2
haraken
LGTM
5 years, 11 months ago (2015-01-21 05:25:17 UTC) #3
kouhei (in TOK)
Sorry. Not lgtm yet. I think we should keep sweep metric to measure total time ...
5 years, 11 months ago (2015-01-21 05:29:13 UTC) #4
haraken
> Also I'm not sure if oilpan_conservative_lazy_sweep ever happens. What do you mean? Lazy sweeping ...
5 years, 11 months ago (2015-01-21 05:58:25 UTC) #5
kouhei (in TOK)
On 2015/01/21 05:58:25, haraken wrote: > > Also I'm not sure if oilpan_conservative_lazy_sweep ever happens. ...
5 years, 11 months ago (2015-01-21 06:03:57 UTC) #6
peria
On 2015/01/21 05:29:13, kouhei wrote: > Sorry. Not lgtm yet. > > I think we ...
5 years, 11 months ago (2015-01-21 06:15:32 UTC) #7
kouhei (in TOK)
On 2015/01/21 06:15:32, peria wrote: > On 2015/01/21 05:29:13, kouhei wrote: > > Sorry. Not ...
5 years, 11 months ago (2015-01-21 06:18:34 UTC) #8
peria
On 2015/01/21 06:18:34, kouhei wrote: > On 2015/01/21 06:15:32, peria wrote: > > On 2015/01/21 ...
5 years, 11 months ago (2015-01-21 06:36:34 UTC) #9
kouhei (in TOK)
lgtm
5 years, 11 months ago (2015-01-21 06:45:23 UTC) #10
Sami
lgtm. I think the crrev.com link in the description is wrong by the way.
5 years, 11 months ago (2015-01-21 16:09:36 UTC) #11
peria
On 2015/01/21 16:09:36, Sami wrote: > lgtm. I think the http://crrev.com link in the description ...
5 years, 11 months ago (2015-01-22 03:58:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863883003/20001
5 years, 11 months ago (2015-01-22 04:00:05 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-22 06:12:34 UTC) #15
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 06:13:36 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/35f317c778c0c36d1d5df412a7f0a97cc3dfdb78
Cr-Commit-Position: refs/heads/master@{#312572}

Powered by Google App Engine
This is Rietveld 408576698