Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Side by Side Diff: tools/perf/measurements/oilpan_gc_times.py

Issue 863883003: [Oilpan] Split sweep phase in tracing into two categories (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a metric of total time of sweeping Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import os 5 import os
6 6
7 from measurements import smoothness_controller 7 from measurements import smoothness_controller
8 from measurements import timeline_controller 8 from measurements import timeline_controller
9 from telemetry.core.platform import tracing_category_filter 9 from telemetry.core.platform import tracing_category_filter
10 from telemetry.core.platform import tracing_options 10 from telemetry.core.platform import tracing_options
11 from telemetry.page import page_test 11 from telemetry.page import page_test
12 from telemetry.page.actions import action_runner 12 from telemetry.page.actions import action_runner
13 from telemetry.timeline.model import TimelineModel 13 from telemetry.timeline.model import TimelineModel
14 from telemetry.util import statistics 14 from telemetry.util import statistics
15 from telemetry.value import list_of_scalar_values 15 from telemetry.value import list_of_scalar_values
16 from telemetry.value import scalar 16 from telemetry.value import scalar
17 from telemetry.value import trace 17 from telemetry.value import trace
18 18
19 19
20 _CR_RENDERER_MAIN = 'CrRendererMain' 20 _CR_RENDERER_MAIN = 'CrRendererMain'
21 _RUN_SMOOTH_ACTIONS = 'RunSmoothAllActions' 21 _RUN_SMOOTH_ACTIONS = 'RunSmoothAllActions'
22 _NAMES_TO_DUMP = ['oilpan_precise_mark', 22 _NAMES_TO_DUMP = ['oilpan_precise_mark',
23 'oilpan_precise_sweep', 23 'oilpan_precise_lazy_sweep',
24 'oilpan_precise_complete_sweep',
24 'oilpan_conservative_mark', 25 'oilpan_conservative_mark',
25 'oilpan_conservative_sweep', 26 'oilpan_conservative_lazy_sweep',
27 'oilpan_conservative_complete_sweep',
26 'oilpan_coalesce'] 28 'oilpan_coalesce']
27 29
28 def _AddTracingResults(events, results): 30 def _AddTracingResults(events, results):
29 # Prepare 31 # Prepare
30 values = {} 32 values = {}
31 for name in _NAMES_TO_DUMP: 33 for name in _NAMES_TO_DUMP:
32 values[name] = [] 34 values[name] = []
33 35
34 # Parse in time line 36 # Parse in time line
35 gc_type = None 37 gc_type = None
36 forced = False 38 forced = False
37 mark_time = 0 39 mark_time = 0
38 sweep_time = 0 40 lazy_sweep_time = 0
41 complete_sweep_time = 0
39 for event in events: 42 for event in events:
40 duration = event.thread_duration or event.duration 43 duration = event.thread_duration or event.duration
41 if event.name == 'ThreadHeap::coalesce': 44 if event.name == 'ThreadHeap::coalesce':
42 values['oilpan_coalesce'].append(duration) 45 values['oilpan_coalesce'].append(duration)
43 continue 46 continue
44 if event.name == 'Heap::collectGarbage': 47 if event.name == 'Heap::collectGarbage':
45 if not gc_type is None and not forced: 48 if not gc_type is None and not forced:
46 values['oilpan_%s_mark' % gc_type].append(mark_time) 49 values['oilpan_%s_mark' % gc_type].append(mark_time)
47 values['oilpan_%s_sweep' % gc_type].append(sweep_time) 50 values['oilpan_%s_lazy_sweep' % gc_type].append(lazy_sweep_time)
51 values['oilpan_%s_complete_sweep' % gc_type].append(complete_sweep_time)
48 52
49 gc_type = 'precise' if event.args['precise'] else 'conservative' 53 gc_type = 'precise' if event.args['precise'] else 'conservative'
50 forced = event.args['forced'] 54 forced = event.args['forced']
51 mark_time = duration 55 mark_time = duration
52 sweep_time = 0 56 lazy_sweep_time = 0
57 complete_sweep_time = 0
53 continue 58 continue
54 if event.name == 'ThreadState::performPendingSweep': 59 if event.name == 'ThreadHeap::lazySweepPages':
55 sweep_time += duration 60 lazy_sweep_time += duration
61 continue
62 if event.name == 'ThreadState::completeSweep':
63 complete_sweep_time += duration
56 continue 64 continue
57 65
58 if not gc_type is None and not forced: 66 if not gc_type is None and not forced:
59 values['oilpan_%s_mark' % gc_type].append(mark_time) 67 values['oilpan_%s_mark' % gc_type].append(mark_time)
60 values['oilpan_%s_sweep' % gc_type].append(sweep_time) 68 values['oilpan_%s_lazy_sweep' % gc_type].append(lazy_sweep_time)
69 values['oilpan_%s_complete_sweep' % gc_type].append(complete_sweep_time)
61 70
62 # Dump 71 # Dump
63 page = results.current_page 72 page = results.current_page
64 unit = 'ms' 73 unit = 'ms'
65 for name in _NAMES_TO_DUMP: 74 for name in _NAMES_TO_DUMP:
66 if values[name]: 75 if values[name]:
67 results.AddValue(list_of_scalar_values.ListOfScalarValues( 76 results.AddValue(list_of_scalar_values.ListOfScalarValues(
68 page, name, unit, values[name])) 77 page, name, unit, values[name]))
69 results.AddValue(scalar.ScalarValue( 78 results.AddValue(scalar.ScalarValue(
70 page, name + '_max', unit, max(values[name]))) 79 page, name + '_max', unit, max(values[name])))
71 results.AddValue(scalar.ScalarValue( 80 results.AddValue(scalar.ScalarValue(
72 page, name + '_total', unit, sum(values[name]))) 81 page, name + '_total', unit, sum(values[name])))
73 82
74 for do_type in ['mark', 'sweep']: 83 # Summarize marking time
75 work_time = 0 84 total_mark_time = 0
85 for gc_type in ['precise', 'conservative']:
86 total_mark_time += sum(values['oilpan_%s_mark' % gc_type])
87 results.AddValue(
88 scalar.ScalarValue(page, 'oilpan_mark', unit, total_mark_time))
89
90 # Summarize sweeping time
91 total_sweep_time = 0
92 for do_type in ['lazy_sweep', 'complete_sweep']:
93 sweep_time = 0
76 for gc_type in ['precise', 'conservative']: 94 for gc_type in ['precise', 'conservative']:
77 work_time += sum(values['oilpan_%s_%s' % (gc_type, do_type)]) 95 sweep_time += sum(values['oilpan_%s_%s' % (gc_type, do_type)])
78 key = 'oilpan_%s' % do_type 96 key = 'oilpan_%s' % do_type
79 results.AddValue(scalar.ScalarValue(page, key, unit, work_time)) 97 results.AddValue(scalar.ScalarValue(page, key, unit, sweep_time))
98 total_sweep_time += sweep_time
99 results.AddValue(
100 scalar.ScalarValue(page, 'oilpan_sweep', unit, total_sweep_time))
80 101
81 gc_time = 0 102 gc_time = 0
82 for key in values: 103 for key in values:
83 gc_time += sum(values[key]) 104 gc_time += sum(values[key])
84 results.AddValue(scalar.ScalarValue(page, 'oilpan_gc', unit, gc_time)) 105 results.AddValue(scalar.ScalarValue(page, 'oilpan_gc', unit, gc_time))
85 106
86 107
87 class _OilpanGCTimesBase(page_test.PageTest): 108 class _OilpanGCTimesBase(page_test.PageTest):
88 def __init__(self, action_name = ''): 109 def __init__(self, action_name = ''):
89 super(_OilpanGCTimesBase, self).__init__(action_name) 110 super(_OilpanGCTimesBase, self).__init__(action_name)
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 170
150 class OilpanGCTimesForInternals(_OilpanGCTimesBase): 171 class OilpanGCTimesForInternals(_OilpanGCTimesBase):
151 def __init__(self): 172 def __init__(self):
152 super(OilpanGCTimesForInternals, self).__init__() 173 super(OilpanGCTimesForInternals, self).__init__()
153 174
154 @classmethod 175 @classmethod
155 def CustomizeBrowserOptions(cls, options): 176 def CustomizeBrowserOptions(cls, options):
156 # 'expose-internals-for-testing' can be enabled on content shell. 177 # 'expose-internals-for-testing' can be enabled on content shell.
157 assert 'content-shell' in options.browser_type 178 assert 'content-shell' in options.browser_type
158 options.AppendExtraBrowserArgs('--expose-internals-for-testing') 179 options.AppendExtraBrowserArgs('--expose-internals-for-testing')
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698