Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 863873003: Fix unnecessary output of decimals in SVG tests. (Closed)

Created:
5 years, 11 months ago by Daniel Bratell
Modified:
5 years, 10 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix unnecessary output of decimals in SVG tests. If a number was slightly below an integer such as 4.99999952 it would be printed as "5.00" instead of the expected "5". R=jchaffraix@chromium.org, fs@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188742

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M LayoutTests/platform/linux/svg/batik/masking/maskRegions-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/svg/custom/masking-clipping-hidpi-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/svg/zoom/page/zoom-mask-with-percentages-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/svg/batik/text/textEffect3-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/svg/custom/masking-clipping-hidpi-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/svg/filters/sourceAlpha-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/svg/batik/text/textEffect3-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/svg/custom/masking-clipping-hidpi-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/svg/filters/sourceAlpha-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/svg/zoom/page/zoom-mask-with-percentages-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/batik/masking/maskRegions-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/text/TextStream.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Daniel Bratell
The safe and trivial part of the svg flake fixes. This fixes no flakes so ...
5 years, 11 months ago (2015-01-21 08:47:40 UTC) #1
Daniel Bratell
Doh, the change is in platforms not svg. jchaffraix, could you take a look at ...
5 years, 11 months ago (2015-01-21 09:47:14 UTC) #3
fs
On 2015/01/21 09:47:14, Daniel Bratell wrote: > Doh, the change is in platforms not svg. ...
5 years, 11 months ago (2015-01-21 10:09:38 UTC) #4
Julien - ping for review
lgtm Ideally we would want to unit test hasFraction to document its behavior. Also I ...
5 years, 11 months ago (2015-01-21 10:35:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863873003/1
5 years, 11 months ago (2015-01-21 12:17:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=188742
5 years, 11 months ago (2015-01-21 14:18:25 UTC) #8
pdr.
5 years, 10 months ago (2015-01-30 23:24:42 UTC) #9
Message was sent while issue was closed.
On 2015/01/21 at 14:18:25, commit-bot wrote:
> Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188742

LGTM!

(clearly I am reading email backwards :)

Powered by Google App Engine
This is Rietveld 408576698