Plugin Power Saver: Make Unthrottle metric collection more consistent

Plugin Power Saver: Make Unthrottle metric collection more consistent

- Makes Plugin Power Saver posters (using LoadablePluginPlaceholder) generate correct metrics.
- Makes the PluginInstanceThrottler report the NEVER unthrottle method correctly.

BUG=449251, 403800
Committed: https://crrev.com/09d49819a8e9d240384963eb21552694aaf22270
Cr-Commit-Position: refs/heads/master@{#312894}

[tommycli, 2015-01-20 23:40:37]

tommycli@chromium.org changed reviewers:
+ dmichael@chromium.org

[tommycli, 2015-01-22 23:07:34]

tommycli@chromium.org changed reviewers:
+ bauerb@chromium.org

[tommycli, 2015-01-22 23:08:08]

tommycli@chromium.org changed reviewers:
+ piman@chromium.org
- dmichael@chromium.org

[tommycli, 2015-01-22 23:20:49]

bauerb, piman: PTAL

Thanks!!!

[piman, 2015-01-23 00:37:12]

lgtm

[Bernhard Bauer, 2015-01-23 11:24:59]

https://codereview.chromium.org/863813002/diff/60001/content/public/renderer/...
File content/public/renderer/plugin_instance_throttler.cc (right):

https://codereview.chromium.org/863813002/diff/60001/content/public/renderer/...
content/public/renderer/plugin_instance_throttler.cc:14: const char
kPowerSaverUnthrottleHistogram[] = "Plugin.PowerSaver.Unthrottle";
Add an empty line after this one? Alternatively, the anonymous namespace isn't
necessary for constants, as they automatically get internal linkage. Or as yet
another alternative, just inline the histogram name? :)

https://codereview.chromium.org/863813002/diff/60001/content/public/renderer/...
content/public/renderer/plugin_instance_throttler.cc:40: }  // namespace content
Now that I look at this: The contents of this file should probably be in
plugin_instance_throttler_impl.cc instead. Code in public/ is only things that
are required outside of content/ (and implementations of static methods aren't,
because they can just be linked in).

[tommycli, 2015-01-23 18:04:41]

Patchset #5 (id:80001) has been deleted

[tommycli, 2015-01-23 18:05:59]

bauerb: Thanks! I had no idea you could just put the static method impls in the
separate module.

https://codereview.chromium.org/863813002/diff/60001/content/public/renderer/...
File content/public/renderer/plugin_instance_throttler.cc (right):

https://codereview.chromium.org/863813002/diff/60001/content/public/renderer/...
content/public/renderer/plugin_instance_throttler.cc:14: const char
kPowerSaverUnthrottleHistogram[] = "Plugin.PowerSaver.Unthrottle";
On 2015/01/23 11:24:59, Bernhard Bauer wrote:
> Add an empty line after this one? Alternatively, the anonymous namespace isn't
> necessary for constants, as they automatically get internal linkage. Or as yet
> another alternative, just inline the histogram name? :)

Done.

https://codereview.chromium.org/863813002/diff/60001/content/public/renderer/...
content/public/renderer/plugin_instance_throttler.cc:40: }  // namespace content
On 2015/01/23 11:24:59, Bernhard Bauer wrote:
> Now that I look at this: The contents of this file should probably be in
> plugin_instance_throttler_impl.cc instead. Code in public/ is only things that
> are required outside of content/ (and implementations of static methods
aren't,
> because they can just be linked in).

Done.

[Bernhard Bauer, 2015-01-23 18:12:57]

LGTM!

[tommycli, 2015-01-23 18:16:43]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2015-01-23 18:16:58]

cool, thanks all!

[commit-bot: I haz the power, 2015-01-23 18:17:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/863813002/100001

[commit-bot: I haz the power, 2015-01-23 19:30:08]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2015-01-23 19:31:10]

Patchset 5 (id:??) landed as
https://crrev.com/09d49819a8e9d240384963eb21552694aaf22270
Cr-Commit-Position: refs/heads/master@{#312894}