Plugin Power Saver: Make Unthrottle metric collection more consistent

content/public/renderer/plugin_instance_throttler.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/renderer/plugin_instance_throttler.h"
 
+#include "base/metrics/histogram.h"
 #include "content/renderer/pepper/plugin_instance_throttler_impl.h"
 
 namespace content {
 
+namespace {
+
+const char kPowerSaverUnthrottleHistogram[] = "Plugin.PowerSaver.Unthrottle";

[Bernhard Bauer, 2015/01/23 11:24:59]

Add an empty line after this one? Alternatively, the anonymous namespace isn't
necessary for constants, as they automatically get internal linkage. Or as yet
another alternative, just inline the histogram name? :)

[tommycli, 2015/01/23 18:05:59]

Done.

+}
+
 // static
 scoped_ptr<PluginInstanceThrottler> PluginInstanceThrottler::Get(
     RenderFrame* frame,
     const GURL& plugin_url,
     PluginPowerSaverMode power_saver_mode) {
   if (power_saver_mode == PluginPowerSaverMode::POWER_SAVER_MODE_ESSENTIAL)
     return nullptr;
 
   bool power_saver_enabled =
       power_saver_mode ==
       PluginPowerSaverMode::POWER_SAVER_MODE_PERIPHERAL_THROTTLED;
   return make_scoped_ptr(
       new PluginInstanceThrottlerImpl(frame, plugin_url, power_saver_enabled));
 }
 
+// static
+void PluginInstanceThrottler::RecordUnthrottleMethodMetric(
+    PluginInstanceThrottlerImpl::PowerSaverUnthrottleMethod method) {
+  UMA_HISTOGRAM_ENUMERATION(
+      kPowerSaverUnthrottleHistogram, method,
+      PluginInstanceThrottler::UNTHROTTLE_METHOD_NUM_ITEMS);
+}
+
 }  // namespace content

[Bernhard Bauer, 2015/01/23 11:24:59]

Now that I look at this: The contents of this file should probably be in
plugin_instance_throttler_impl.cc instead. Code in public/ is only things that
are required outside of content/ (and implementations of static methods aren't,
because they can just be linked in).

[tommycli, 2015/01/23 18:05:59]

Done.