Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 863543002: NaCl docs: a few improvements (Closed)

Created:
5 years, 11 months ago by JF
Modified:
5 years, 11 months ago
Reviewers:
jpmedley, binji
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl docs: a few improvements * Mention Stack Overflow in more places. * Add https to a few links that support it, instead of http. I wasn't exhaustive in my replacement, we should probably do a full sweep at some point. * Expand on the languages section a bit. * Comment out the broken "talk" link. TEST= none BUG= none TBR= binji@chromium.org, jmedley@chromium.org NOTRY=true (documentation only change) Committed: https://chromium.googlesource.com/chromium/src/+/d8377eb3f7c6e38ea2a63801d8a570128b90ebd0

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -34 lines) Patch
M native_client_sdk/doc_generated/cds2014/cpp.html View 2 chunks +4 lines, -4 lines 0 comments Download
M native_client_sdk/doc_generated/cds2014/python.html View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/index.html View 1 chunk +3 lines, -2 lines 0 comments Download
M native_client_sdk/doc_generated/faq.html View 1 chunk +5 lines, -1 line 0 comments Download
M native_client_sdk/doc_generated/help.html View 2 chunks +2 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/index.html View 2 chunks +3 lines, -2 lines 0 comments Download
M native_client_sdk/src/doc/cds2014/cpp.rst View 3 chunks +7 lines, -5 lines 0 comments Download
M native_client_sdk/src/doc/cds2014/python.rst View 1 chunk +4 lines, -3 lines 0 comments Download
M native_client_sdk/src/doc/devguide/index.rst View 1 chunk +5 lines, -3 lines 0 comments Download
M native_client_sdk/src/doc/faq.rst View 2 chunks +9 lines, -1 line 2 comments Download
M native_client_sdk/src/doc/help.rst View 2 chunks +4 lines, -5 lines 0 comments Download
M native_client_sdk/src/doc/index.rst View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
JF
5 years, 11 months ago (2015-01-19 18:04:30 UTC) #1
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d8377eb3f7c6e38ea2a63801d8a570128b90ebd0 Cr-Commit-Position: refs/heads/master@{#312133}
5 years, 11 months ago (2015-01-19 18:08:00 UTC) #2
JF
Committed patchset #1 (id:1) manually as d8377eb3f7c6e38ea2a63801d8a570128b90ebd0 (presubmit successful).
5 years, 11 months ago (2015-01-19 18:08:03 UTC) #3
jpmedley
lgtm
5 years, 11 months ago (2015-01-20 15:43:54 UTC) #4
binji
https://codereview.chromium.org/863543002/diff/1/native_client_sdk/src/doc/faq.rst File native_client_sdk/src/doc/faq.rst (right): https://codereview.chromium.org/863543002/diff/1/native_client_sdk/src/doc/faq.rst#newcode240 native_client_sdk/src/doc/faq.rst:240: languages such as Rust_, Go_, or Objective-C, but there ...
5 years, 11 months ago (2015-01-20 18:34:51 UTC) #5
JF
5 years, 11 months ago (2015-01-20 19:23:12 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/863543002/diff/1/native_client_sdk/src/doc/fa...
File native_client_sdk/src/doc/faq.rst (right):

https://codereview.chromium.org/863543002/diff/1/native_client_sdk/src/doc/fa...
native_client_sdk/src/doc/faq.rst:240: languages such as Rust_, Go_, or
Objective-C, but there may still be a few rough
On 2015/01/20 18:34:51, binji wrote:
> This is kind of already mentioned above (Halide, Haskell, etc.) Maybe combine
> these?

Good point, I'll update.

Powered by Google App Engine
This is Rietveld 408576698