Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 863393002: Archive binaries on the deterministic build. (Closed)

Created:
5 years, 11 months ago by M-A Ruel
Modified:
5 years, 11 months ago
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Archive binaries on the deterministic build. This has two goals: - Archive the binaries for inspection. - Fix the .isolated, as the .isolated files will be different after the step remove_build_metadata ran. This caused false-positives on the diffing on OSes where remove_build_metadata is not a no-op. R=sebmarchand@chromium.org BUG=314403 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293758

Patch Set 1 : . #

Messages

Total messages: 6 (2 generated)
M-A Ruel
"I think it'll work". If it doesn't, we'll see quickly enough.
5 years, 11 months ago (2015-01-22 20:59:39 UTC) #2
Sébastien Marchand
lgtm
5 years, 11 months ago (2015-01-22 21:09:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/863393002/20001
5 years, 11 months ago (2015-01-22 21:10:35 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 21:13:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293758

Powered by Google App Engine
This is Rietveld 408576698