Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: scripts/slave/recipes/swarming/deterministic_build.py

Issue 863393002: Archive binaries on the deterministic build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: . Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Android_deterministic_build.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/swarming/deterministic_build.py
diff --git a/scripts/slave/recipes/swarming/deterministic_build.py b/scripts/slave/recipes/swarming/deterministic_build.py
index d45ef02f0649b3023f13f483e88890720ea4ac19..0a2ad5e100f8bcce67f8acebb6e3a2d580013837 100644
--- a/scripts/slave/recipes/swarming/deterministic_build.py
+++ b/scripts/slave/recipes/swarming/deterministic_build.py
@@ -95,6 +95,9 @@ def GenSteps(api):
for c in recipe_config.get('gclient_apply_config', []):
api.gclient.apply_config(c)
+ # Enable test isolation. Modifies GYP_DEFINES used in 'runhooks' below.
+ api.isolate.set_isolate_environment(api.chromium.c)
+
# Checkout chromium.
api.bot_update.ensure_checkout(force=True)
@@ -102,6 +105,8 @@ def GenSteps(api):
api.chromium.runhooks()
api.chromium.compile(targets, force_clobber=True, name='First build')
api.isolate.remove_build_metadata()
+ # This archives the results and regenerate the .isolated files.
+ api.isolate.isolate_tests(api.chromium.output_dir)
MoveBuildDirectory(api, str(api.chromium.output_dir),
str(api.chromium.output_dir).rstrip('\\/') + '.1')
@@ -109,6 +114,8 @@ def GenSteps(api):
api.chromium.runhooks()
api.chromium.compile(targets, force_clobber=True, name='Second build')
api.isolate.remove_build_metadata()
+ # This should be quick if the build is indeed deterministic.
+ api.isolate.isolate_tests(api.chromium.output_dir)
MoveBuildDirectory(api, str(api.chromium.output_dir),
str(api.chromium.output_dir).rstrip('\\/') + '.2')
« no previous file with comments | « no previous file | scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Android_deterministic_build.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698