Convert compiler cctest to unittests: SchedulerTest

Convert compiler cctest to unittests: SchedulerTest

R=mstarzinger@chromium.org
LOG=N

Committed: https://crrev.com/c6ae3733350acadc1fabcf41fab9b97799ef5dd5
Cr-Commit-Position: refs/heads/master@{#26267}

[danno, 2015-01-22 15:24:55]

PTAL

[Michael Starzinger, 2015-01-22 16:10:36]

https://codereview.chromium.org/863213003/diff/1/test/unittests/compiler/sche...
File test/unittests/compiler/scheduler-unittest.cc (right):

https://codereview.chromium.org/863213003/diff/1/test/unittests/compiler/sche...
test/unittests/compiler/scheduler-unittest.cc:35: static void
CheckRPONumbers(BasicBlockVector* order, size_t expected,
These static methods could be made into member methods on the test class now.
Also there seem to be two fundamental groups of tests (i.e. the RPO-tests and
the graph-based ones) and we could have two test classes for that purpose,
making that separation clear.

https://codereview.chromium.org/863213003/diff/1/test/unittests/compiler/sche...
test/unittests/compiler/scheduler-unittest.cc:671: Handle<HeapObject> object =
I am not an expert on how the unit-tests should be structured, but should be
have helper methods providing these objects? Maybe Benedikt has an opinion.

[danno, 2015-01-23 16:51:36]

Please take another look

https://codereview.chromium.org/863213003/diff/1/test/unittests/compiler/sche...
File test/unittests/compiler/scheduler-unittest.cc (right):

https://codereview.chromium.org/863213003/diff/1/test/unittests/compiler/sche...
test/unittests/compiler/scheduler-unittest.cc:35: static void
CheckRPONumbers(BasicBlockVector* order, size_t expected,
On 2015/01/22 16:10:36, Michael Starzinger wrote:
> These static methods could be made into member methods on the test class now.
> Also there seem to be two fundamental groups of tests (i.e. the RPO-tests and
> the graph-based ones) and we could have two test classes for that purpose,
> making that separation clear.

Done.

https://codereview.chromium.org/863213003/diff/1/test/unittests/compiler/sche...
test/unittests/compiler/scheduler-unittest.cc:671: Handle<HeapObject> object =
On 2015/01/22 16:10:36, Michael Starzinger wrote:
> I am not an expert on how the unit-tests should be structured, but should be
> have helper methods providing these objects? Maybe Benedikt has an opinion.

Done.

[Michael Starzinger, 2015-01-26 09:52:31]

LGTM.

[danno, 2015-01-26 10:59:19]

The CQ bit was checked by danno@chromium.org

[commit-bot: I haz the power, 2015-01-26 11:00:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/863213003/80001

[commit-bot: I haz the power, 2015-01-26 11:21:21]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-01-26 11:21:31]

Patchset 5 (id:??) landed as
https://crrev.com/c6ae3733350acadc1fabcf41fab9b97799ef5dd5
Cr-Commit-Position: refs/heads/master@{#26267}