test/unittests/test-utils.h - Issue 863213003: Convert compiler cctest to unittests: SchedulerTest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/test-utils.h

Issue 863213003: Convert compiler cctest to unittests: SchedulerTest (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: More cleanup Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/unittests/test-utils.h

diff --git a/test/unittests/test-utils.h b/test/unittests/test-utils.h

index 765b97dd3798b0d9fecfaefd5750bd6a5eae1ece..42831a7db084c559e25f8ed306571195125a495b 100644

--- a/test/unittests/test-utils.h

+++ b/test/unittests/test-utils.h

@@ -16,7 +16,7 @@ namespace v8 {

std::ostream& operator<<(std::ostream&, ExternalArrayType);

-class TestWithIsolate : public ::testing::Test {

+class TestWithIsolate : public virtual ::testing::Test {

public:

TestWithIsolate();

virtual ~TestWithIsolate();

« no previous file with comments | « test/unittests/compiler/scheduler-unittest.cc ('k') | test/unittests/unittests.gyp » ('j') | no next file with comments »