Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 862963002: Add missing FrameState to JSTypedLoweringTester. (Closed)

Created:
5 years, 11 months ago by Michael Starzinger
Modified:
5 years, 11 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-runtime-todo
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add missing FrameState to JSTypedLoweringTester. R=titzer@chromium.org TEST=cctest/test-js-typed-lowering/JSToNumberOfNumberOrOtherPrimitive Committed: https://crrev.com/65eb16178d78ef09861a4116d631efa02cf93a93 Cr-Commit-Position: refs/heads/master@{#26194}

Patch Set 1 #

Patch Set 2 : Drop bogus TODO. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M test/cctest/cctest.status View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 11 months ago (2015-01-21 13:58:44 UTC) #1
titzer
lgtm
5 years, 11 months ago (2015-01-21 14:03:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/862963002/20001
5 years, 11 months ago (2015-01-21 14:04:18 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-21 14:33:50 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 14:34:02 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/65eb16178d78ef09861a4116d631efa02cf93a93
Cr-Commit-Position: refs/heads/master@{#26194}

Powered by Google App Engine
This is Rietveld 408576698