Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Side by Side Diff: test/cctest/compiler/test-js-typed-lowering.cc

Issue 862963002: Add missing FrameState to JSTypedLoweringTester. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_cleanup-runtime-todo
Patch Set: Drop bogus TODO. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/cctest.status ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/graph-inl.h" 5 #include "src/compiler/graph-inl.h"
6 #include "src/compiler/js-graph.h" 6 #include "src/compiler/js-graph.h"
7 #include "src/compiler/js-typed-lowering.h" 7 #include "src/compiler/js-typed-lowering.h"
8 #include "src/compiler/machine-operator.h" 8 #include "src/compiler/machine-operator.h"
9 #include "src/compiler/node-properties-inl.h" 9 #include "src/compiler/node-properties-inl.h"
10 #include "src/compiler/opcodes.h" 10 #include "src/compiler/opcodes.h"
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 return reduce(Binop(op, Parameter(left_type, 0), Parameter(right_type, 1))); 111 return reduce(Binop(op, Parameter(left_type, 0), Parameter(right_type, 1)));
112 } 112 }
113 113
114 Node* Binop(const Operator* op, Node* left, Node* right) { 114 Node* Binop(const Operator* op, Node* left, Node* right) {
115 // JS binops also require context, effect, and control 115 // JS binops also require context, effect, and control
116 return graph.NewNode(op, left, right, context(), start(), control()); 116 return graph.NewNode(op, left, right, context(), start(), control());
117 } 117 }
118 118
119 Node* Unop(const Operator* op, Node* input) { 119 Node* Unop(const Operator* op, Node* input) {
120 // JS unops also require context, effect, and control 120 // JS unops also require context, effect, and control
121 return graph.NewNode(op, input, context(), start(), control()); 121 if (OperatorProperties::HasFrameStateInput(op)) {
122 return graph.NewNode(op, input, context(), EmptyFrameState(context()),
123 start(), control());
124 } else {
125 return graph.NewNode(op, input, context(), start(), control());
126 }
122 } 127 }
123 128
124 Node* UseForEffect(Node* node) { 129 Node* UseForEffect(Node* node) {
125 // TODO(titzer): use EffectPhi after fixing EffectCount 130 // TODO(titzer): use EffectPhi after fixing EffectCount
126 if (OperatorProperties::HasFrameStateInput(javascript.ToNumber())) { 131 if (OperatorProperties::HasFrameStateInput(javascript.ToNumber())) {
127 return graph.NewNode(javascript.ToNumber(), node, context(), 132 return graph.NewNode(javascript.ToNumber(), node, context(),
128 EmptyFrameState(context()), node, control()); 133 EmptyFrameState(context()), node, control());
129 } else { 134 } else {
130 return graph.NewNode(javascript.ToNumber(), node, context(), node, 135 return graph.NewNode(javascript.ToNumber(), node, context(), node,
131 control()); 136 control());
(...skipping 1143 matching lines...) Expand 10 before | Expand all | Expand 10 after
1275 CHECK_EQ(p1, r->InputAt(0)); 1280 CHECK_EQ(p1, r->InputAt(0));
1276 CHECK_EQ(p0, r->InputAt(1)); 1281 CHECK_EQ(p0, r->InputAt(1));
1277 } else { 1282 } else {
1278 CHECK_EQ(p0, r->InputAt(0)); 1283 CHECK_EQ(p0, r->InputAt(0));
1279 CHECK_EQ(p1, r->InputAt(1)); 1284 CHECK_EQ(p1, r->InputAt(1));
1280 } 1285 }
1281 } 1286 }
1282 } 1287 }
1283 } 1288 }
1284 } 1289 }
OLDNEW
« no previous file with comments | « test/cctest/cctest.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698