Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 862943009: Fix Windows build warning (Closed)

Created:
5 years, 10 months ago by JF
Modified:
5 years, 10 months ago
Reviewers:
kschimpf
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-llvm.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix Windows build warning Another fix for: https://codereview.chromium.org/863093002 GCC 4.8.1 is again being silly and thinking control reaches end of non-void function. TBR= kschimpf@chromium.org BUG=none Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=96604fa21c831e9968a1c25438e1895b3aa6bf3a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M lib/Analysis/NaCl/PNaClABIProps.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
JF
5 years, 10 months ago (2015-01-27 17:18:08 UTC) #1
JF
5 years, 10 months ago (2015-01-27 17:18:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
96604fa21c831e9968a1c25438e1895b3aa6bf3a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698