Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 862823004: Revert of GrBatchPrototype (Closed)

Created:
5 years, 10 months ago by joshualitt
Modified:
5 years, 10 months ago
Reviewers:
bsalomon, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@lc2
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of GrBatchPrototype (patchset #30 id:570001 of https://codereview.chromium.org/845103005/) Reason for revert: creates large performance regression Original issue's description: > GrBatchPrototype > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/d15e4e45374275c045572b304c229237c4a82be4 TBR=bsalomon@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/ca0a1799ffdceb4ccd998468566f39abac2f0b55

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+316 lines, -1154 lines) Patch
D gm/dstreadshuffle.cpp View 1 chunk +0 lines, -185 lines 0 comments Download
M gyp/gmslides.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M gyp/gpu.gypi View 2 chunks +1 line, -4 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 6 chunks +162 lines, -344 lines 0 comments Download
D src/gpu/GrBatch.h View 1 chunk +0 lines, -132 lines 0 comments Download
D src/gpu/GrBatch.cpp View 1 chunk +0 lines, -35 lines 0 comments Download
D src/gpu/GrBatchTarget.h View 1 chunk +0 lines, -78 lines 0 comments Download
D src/gpu/GrBatchTarget.cpp View 1 chunk +0 lines, -32 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawTarget.h View 7 chunks +4 lines, -22 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 2 chunks +2 lines, -25 lines 0 comments Download
M src/gpu/GrFlushToGpuDrawTarget.h View 1 chunk +0 lines, -3 lines 0 comments Download
A src/gpu/GrGeometryData.h View 1 chunk +42 lines, -0 lines 0 comments Download
M src/gpu/GrGeometryProcessor.h View 6 chunks +15 lines, -19 lines 0 comments Download
M src/gpu/GrGeometryProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 8 chunks +7 lines, -43 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 10 chunks +7 lines, -89 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrPipeline.h View 4 chunks +4 lines, -16 lines 0 comments Download
M src/gpu/GrPipeline.cpp View 2 chunks +4 lines, -29 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 4 chunks +11 lines, -29 lines 0 comments Download
M src/gpu/GrPipelineBuilder.cpp View 4 chunks +19 lines, -19 lines 0 comments Download
M src/gpu/GrProcOptInfo.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/gpu/GrProcOptInfo.cpp View 1 chunk +0 lines, -19 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 2 chunks +14 lines, -0 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
joshualitt
Created Revert of GrBatchPrototype
5 years, 10 months ago (2015-01-27 14:40:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/862823004/1
5 years, 10 months ago (2015-01-27 14:41:08 UTC) #2
commit-bot: I haz the power
5 years, 10 months ago (2015-01-27 14:41:37 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ca0a1799ffdceb4ccd998468566f39abac2f0b55

Powered by Google App Engine
This is Rietveld 408576698