Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 862503002: Revert of On Android, links inside headings should be announced as headings by TalkBack (Closed)

Created:
5 years, 11 months ago by bartfab (slow)
Modified:
5 years, 11 months ago
Reviewers:
ramya.v, dmazzoni, aboxhall
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of On Android, links inside headings should be announced as headings by TalkBack (patchset #4 id:60001 of https://codereview.chromium.org/845663002/) Reason for revert: This caused content_browsertests to fail on the Android bots, e.g.: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/17857 C 1232.064s Main [FAIL] DumpAccessibilityTreeTest.AccessibilityLinkInsideHeading: C 1232.064s Main [WARNING:dns_config_service_posix.cc(293)] Failed to read DnsConfig. C 1232.065s Main [ERROR:unix_domain_server_socket_posix.cc(106)] Not implemented reached in virtual int net::UnixDomainServerSocket::GetLocalAddress(net::IPEndPoint*) const C 1232.065s Main [WARNING:proxy_service.cc(899)] PAC support disabled because there is no system implementation C 1232.065s Main Testing: /storage/emulated/0/content/test/data/accessibility/html/link-inside-heading.html C 1232.065s Main ../../content/browser/accessibility/dump_accessibility_browsertest_base.cc:202: Failure C 1232.065s Main Value of: is_different C 1232.065s Main Actual: true C 1232.065s Main Expected: false C 1232.065s Main * Line Expected C 1232.065s Main - ---- -------- C 1232.065s Main 1 android.webkit.WebView focusable focused scrollable C 1232.065s Main 2 android.view.View heading C 1232.065s Main * 3 android.view.View clickable focusable heading name='Link In Heading' C 1232.065s Main 4 <-- End-of-file --> C 1232.065s Main C 1232.065s Main Actual C 1232.065s Main ------ C 1232.065s Main android.webkit.WebView focusable focused scrollable C 1232.065s Main android.view.View heading C 1232.066s Main android.view.View clickable focusable heading link name='Link In Heading' C 1232.066s Main <-- End-of-file --> Original issue's description: > On Android, links inside headings should be announced as headings by TalkBack > > BUG=446216 > > Committed: https://crrev.com/68e8e33eff3a16754b9a99681d0586041436bb62 > Cr-Commit-Position: refs/heads/master@{#312086} TBR=dmazzoni@chromium.org,aboxhall@chromium.org,ramya.v@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=446216 Committed: https://crrev.com/4fe2125920ff2503f299d4a12e5d5b291139175b Cr-Commit-Position: refs/heads/master@{#312102}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M content/browser/accessibility/browser_accessibility_android.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
D content/test/data/accessibility/html/link-inside-heading.html View 1 chunk +0 lines, -6 lines 0 comments Download
D content/test/data/accessibility/html/link-inside-heading-expected-android.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D content/test/data/accessibility/html/link-inside-heading-expected-mac.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D content/test/data/accessibility/html/link-inside-heading-expected-win.txt View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bartfab (slow)
Created Revert of On Android, links inside headings should be announced as headings by TalkBack
5 years, 11 months ago (2015-01-19 12:49:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/862503002/1
5 years, 11 months ago (2015-01-19 12:50:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-19 12:50:56 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-19 12:51:55 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4fe2125920ff2503f299d4a12e5d5b291139175b
Cr-Commit-Position: refs/heads/master@{#312102}

Powered by Google App Engine
This is Rietveld 408576698