Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 862403002: IDL: Support [TypeChecking=Interface] correctly on indexed setters (Closed)

Created:
5 years, 11 months ago by Jens Widell
Modified:
5 years, 11 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

IDL: Support [TypeChecking=Interface] correctly on indexed setters Normally, [TypeChecking=Interface] can be set either on an interface as a whole, affecting all its definitions (attributes and methods), or on individual definitions. But for indexed setter definitions setter ElementType (unsigned long index, ElementType value); it had to be set explicitly for the setter definition; setting it only on the interface as a whole did not work. This change affects the following interfaces with indexed setters: SVGLengthList SVGNumberList SVGPathSegList SVGPointList SVGTransformList Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188807

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/bindings/scripts/v8_interface.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jens Widell
PTAL
5 years, 11 months ago (2015-01-22 10:43:41 UTC) #2
haraken
LGTM
5 years, 11 months ago (2015-01-22 11:02:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/862403002/1
5 years, 11 months ago (2015-01-22 11:08:41 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 12:03:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188807

Powered by Google App Engine
This is Rietveld 408576698