Source/bindings/scripts/v8_interface.py - Issue 862403002: IDL: Support [TypeChecking=Interface] correctly on indexed setters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_interface.py

Issue 862403002: IDL: Support [TypeChecking=Interface] correctly on indexed setters (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_interface.py

diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py

index ea2e4368cf708d3a6b7dd7b0371852466b8858a2..535ebeca1b601909de9d568f57766cf1c338f5ed 100644

--- a/Source/bindings/scripts/v8_interface.py

+++ b/Source/bindings/scripts/v8_interface.py

@@ -1184,8 +1184,8 @@ def property_setter(interface, setter):

has_extended_attribute_value(setter, 'TypeChecking', 'Unrestricted'))

return {

'has_type_checking_interface':

- # FIXME: check interface's [TypeChecking] attribute too.

- has_extended_attribute_value(setter, 'TypeChecking', 'Interface') and

+ (has_extended_attribute_value(interface, 'TypeChecking', 'Interface') or

+ has_extended_attribute_value(setter, 'TypeChecking', 'Interface')) and

idl_type.is_wrapper_type,

'idl_type': idl_type.base_type,

'is_custom': 'Custom' in extended_attributes,

« no previous file with comments | « no previous file | no next file » | no next file with comments »